-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spdlog fails to build with latest fmt #2693
Comments
PR is welcome. |
It seems like won't really be an easy fix without hacky ways, such as definining "FMT_VERSION_MASTER" on cmake option, because their Release fmt version is the same as master fmt, but with breaking differences. If this is something allowed to add, I can make the patch for it, otherwise I don't know a valid fix that would be compatible with both versions. |
The version in fmt head is [the unreleased) 90101, while spdlog use 90100. We can check the fmt version and apply the fix if it is >= 90101 |
Using latest fmt, the spdlog will fail to build.
You must change the basic_runtime to runtime_format_string to fix the issue, however bundled spdlog uses basic_runtime. Line: https://github.com/gabime/spdlog/blob/v1.x/include/spdlog/common.h#L181
The text was updated successfully, but these errors were encountered: