Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog fails to build with latest fmt #2693

Closed
H1X4Dev opened this issue Mar 31, 2023 · 3 comments · Fixed by #2694
Closed

spdlog fails to build with latest fmt #2693

H1X4Dev opened this issue Mar 31, 2023 · 3 comments · Fixed by #2694

Comments

@H1X4Dev
Copy link
Contributor

H1X4Dev commented Mar 31, 2023

Using latest fmt, the spdlog will fail to build.

You must change the basic_runtime to runtime_format_string to fix the issue, however bundled spdlog uses basic_runtime. Line: https://github.com/gabime/spdlog/blob/v1.x/include/spdlog/common.h#L181

@gabime
Copy link
Owner

gabime commented Mar 31, 2023

PR is welcome.

@H1X4Dev
Copy link
Contributor Author

H1X4Dev commented Mar 31, 2023

It seems like won't really be an easy fix without hacky ways, such as definining "FMT_VERSION_MASTER" on cmake option, because their Release fmt version is the same as master fmt, but with breaking differences. If this is something allowed to add, I can make the patch for it, otherwise I don't know a valid fix that would be compatible with both versions.

@gabime
Copy link
Owner

gabime commented Mar 31, 2023

The version in fmt head is [the unreleased) 90101, while spdlog use 90100. We can check the fmt version and apply the fix if it is >= 90101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants