analysis: update docs + add validation analysis #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
commented
May 21, 2024
Comment on lines
+8
to
+19
| A submission tool for submitting to the ClinVar Submission API using [GA4GH Genomic | ||
| Knowledge Standards](https://www.ga4gh.org/work_stream/genomic-knowledge-standards/) | ||
| (GKS) data. | ||
|
|
||
| Development of a shared, open-source software package for managing these submissions | ||
| that can be easily configured for use by multiple submitters would be highly impactful | ||
| as development and adoption of the GKS framework grows. | ||
|
|
||
|  | ||
|
|
||
| We plan to contribute to [ClinVar This](https://github.com/varfish-org/clinvar-this) to | ||
| support GKS data stored as [JSON Lines](https://jsonlines.org/) files. |
There was a problem hiding this comment.
General overview. Should I add anything else?
There was a problem hiding this comment.
I think this looks great.
korikuzma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10
I'm not sure if this will actually become it's own python package or if we'll just leverage ClinVar This for everything, but decided to go ahead and use the python project template@ahwagner @larrybabb Is there additional documentation you'd like me to add?