Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more examples for current models #25

Closed
korikuzma opened this issue Jun 19, 2024 · 6 comments
Closed

add more examples for current models #25

korikuzma opened this issue Jun 19, 2024 · 6 comments
Assignees

Comments

@korikuzma
Copy link
Contributor

Currently there is only an example for ProteinSequenceConsequence. I am working on creating pydantic models for cat-vrs in https://github.com/ga4gh/cat-vrs-python and it would be nice to have examples for the other models to use in tests.

@DanielPuthawala
Copy link
Collaborator

DanielPuthawala commented Jun 20, 2024

You mean in the examples here?

@korikuzma
Copy link
Contributor Author

Yes, it'd be nice to have more examples of other models!

@DanielPuthawala
Copy link
Collaborator

Agreed. We're working on this, but at the same time the conversion to the constraint model is going to necessitate reworking even that example a bit... How soon did you want this and how much/many did you want?

@korikuzma
Copy link
Contributor Author

It's not urgent. It'd be nice to have at least 1 example for each model.

@DanielPuthawala
Copy link
Collaborator

I think I can safely say you will get them!

@korikuzma
Copy link
Contributor Author

This will be handled in #87

@korikuzma korikuzma closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
@brendanreardon brendanreardon moved this to In Progress in Cat-VRS Feb 3, 2025
@brendanreardon brendanreardon moved this from In Progress to Done in Cat-VRS Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants