Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation to the book #700

Closed
trdthg opened this issue Sep 10, 2022 · 8 comments
Closed

Add Chinese translation to the book #700

trdthg opened this issue Sep 10, 2022 · 8 comments

Comments

@trdthg
Copy link

trdthg commented Sep 10, 2022

Hi, I've done a Chinese translation for this book.
(it's mostly done now, except for some deprecated parts and the latest web updates.)
Some people may need it and I will try to catch up with the latest book as much as possible.
So would you like to add a link to the gh-page in the README or merge the translations of the book?

@welcome
Copy link

welcome bot commented Sep 10, 2022

Hi! Thanks for opening your first issue here! 😄

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 10, 2022

Good job!

So would you like to add a link to the gh-page in the README or merge the translations of the book?

Merging the translations LGTM :)

As I am quite active on GitHub, whenever you have some updates, just PR and I usually merge quickly (within minutes or hours).

@trdthg
Copy link
Author

trdthg commented Sep 10, 2022

Thanks : D ( I saw that you mentioned in your book that you replied very quickly, but never thought it would be so fast 😆 )

@trdthg trdthg closed this as completed Sep 10, 2022
@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 10, 2022

I saw that you mentioned in your book that you replied very quickly, but never thought it would be so fast 😆

😆

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 13, 2022

Btw, for a multi-lang book, as suggested in rust-lang/mdBook#5 (comment), maybe we can try about rust-lang/mdBook#1864

@trdthg
Copy link
Author

trdthg commented Sep 14, 2022

Thanks, I'll take a look. Hoping it can make tracking updates easier.
Now I use workflow to copy the translated book directly to the gh-pages branch as a subdirectory and It works fine.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 14, 2022

I see. Take your time!

@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants