We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On v5, this line of code (https://github.com/fzakaria/slf4j-timbre/blob/master/src/slf4j_timbre/factory.clj#L15) outputs:
(require '[taoensso.timbre :as timbre]) => nil (= timbre/*config* (var-get (resolve 'taoensso.timbre/example-config))) => true timbre/*config* => {:min-level :debug, :ns-filter #{"*"}, :middleware [], :timestamp-opts {:pattern :iso8601, :locale :jvm-default, :timezone :utc}, :output-fn #object[taoensso.timbre$default_output_fn 0x2907b20b "taoensso.timbre$default_output_fn@2907b20b"], :appenders {:println {:enabled? true, :async? false, :min-level nil, :rate-limit nil, :output-fn :inherit, :fn #object[taoensso.timbre.appenders.core$println_appender$fn__5755 0x320defc8 "taoensso.timbre.appenders.core$println_appender$fn__5755@320defc8"]}}}
on v6 it outputs:
(require '[taoensso.timbre :as timbre]) => nil (= timbre/*config* (var-get (resolve 'taoensso.timbre/example-config))) => false timbre/*config* => {:min-level :debug, :ns-filter #{"*"}, :middleware [], :timestamp-opts {:pattern :iso8601, :locale :jvm-default, :timezone :utc}, :output-fn #object[taoensso.timbre$default_output_fn 0x53b7e015 "taoensso.timbre$default_output_fn@53b7e015"], :appenders {:println {:enabled? true, :fn #object[taoensso.timbre.appenders.core$println_appender$fn__5835 0x512839d8 "taoensso.timbre.appenders.core$println_appender$fn__5835@512839d8"]}}, :_init-config {:loaded-from-source :default, :compile-time-config {:min-level nil, :ns-pattern "*"}}}
This is because :_init-config is now present in timbre/*config* but not in (var-get (resolve 'taoensso.timbre/example-config)).
:_init-config
timbre/*config*
(var-get (resolve 'taoensso.timbre/example-config))
Because of this, it causes #32 to come back with v6 of timbre and the latest version of this library.
The text was updated successfully, but these errors were encountered:
Adapt init to work with v6 of timbre for fzakaria#67
4a5deb5
@vincentjames501 Hi Vincent - in case this is still relevant for you, you might want to try Timbre v6.6.0-RC1 which now includes built-in SLF4J(v2) support that'll always be automatically kept in-sync with the latest Timbre release.
Sorry, something went wrong.
@ptaoussanis , this is great! We'll roll this into our internal logging library that leverages timbre soon. Thanks again!
Successfully merging a pull request may close this issue.
On v5, this line of code (https://github.com/fzakaria/slf4j-timbre/blob/master/src/slf4j_timbre/factory.clj#L15) outputs:
on v6 it outputs:
This is because
:_init-config
is now present intimbre/*config*
but not in(var-get (resolve 'taoensso.timbre/example-config))
.Because of this, it causes #32 to come back with v6 of timbre and the latest version of this library.
The text was updated successfully, but these errors were encountered: