-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent user-faced fyne error reporting #2982
Comments
I'm not sure that I agree with this - most of the errors reported in LogError are not fatal or even relevant to the user. Quite happy that graphics failures on all platforms could do what Cedric added in #2976, for other aspects I would be tempted to provide an error hook rather than showing every one to the user (especially as none of them are fatal). |
I agree with @andydotxyz on this. I also want to add that, from what I have seen on Linux specifically, it seems like errors usually are printed to the console and are not directly displayed to the user. |
Okay, so let’s leave the |
This would be a nice improvement indeed. For JS, Fyne app are not started if WebGL is not available and the splash screen display an error message directly. In a way, I think it is already done for the web backend to do what fyne.ReportFatalError could do. |
I wonder, would ReportFatalError always do the same thing? I wonder if exporting it for general use and opening the above question is more trouble - how about it's internal and used only for graphics setup as has already been discussed? |
Yeah, restricting it to internal use sounds reasonable. |
Currently, we have a lot of
fyne.LogError
statements putting some kind of erroneous state out tostderr
. #2976 introduced a Windows message box for a certain kind of error because most users and probably many developers would never see this.I suggest, that we should implement
fyne.LogError
in a way that makes these errors visible to the user alongside thestderr
output.This would require a generic message box support for all OS:
xmessage
. If a dialog is not availablenotify-send
might be a usable fallback.stderr
there.The text was updated successfully, but these errors were encountered: