Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Intacct connector page info box for fyle theme #991

Merged
merged 3 commits into from
Oct 1, 2024
Merged

chore: Intacct connector page info box for fyle theme #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7bd5c9
Intacct connector page info box for fyle theme
DhaaraniCIT Oct 1, 2024
ac63bce
Intacct connector page info box for fyle theme
DhaaraniCIT Oct 1, 2024
79872c0
content from content files
DhaaraniCIT Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/branding/c1-contents-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ export const c1Contents = {
connector: {
stepName: 'Connect to Sage Intacct',
subLabel: 'Provide your credentials to establish a secure connection between your Expense Management and Sage Intacct account. ',
locationSubLabel: 'Expenses will be posted to the Sage Intacct location entity selected here. You can\'t change the location entity once they\'re configured.'
locationSubLabel: 'Expenses will be posted to the Sage Intacct location entity selected here. You can\'t change the location entity once they\'re configured.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix pronoun agreement in 'locationSubLabel'

The term 'location entity' is singular, so the pronoun should be singular 'it' instead of 'they' in the sentence "You can't change the location entity once they're configured."

Apply this diff to correct the pronoun:

-locationSubLabel: 'Expenses will be posted to the Sage Intacct location entity selected here. You can\'t change the location entity once they\'re configured.',
+locationSubLabel: 'Expenses will be posted to the Sage Intacct location entity selected here. You can\'t change the location entity once it\'s configured.',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
locationSubLabel: 'Expenses will be posted to the Sage Intacct location entity selected here. You can\'t change the location entity once they\'re configured.',
locationSubLabel: 'Expenses will be posted to the Sage Intacct location entity selected here. You can\'t change the location entity once it\'s configured.',

connectorInfoLabel: 'Make sure you’re entering your integration credentials. These should be different than your Sage Intacct credentials.'
},
exportSetting: {
stepName: 'Export settings',
Expand Down
3 changes: 2 additions & 1 deletion src/app/branding/fyle-contents-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ export const fyleContents = {
connector: {
stepName: 'Connect to Sage Intacct',
locationSubLabel: 'Expenses will be posted to the Sage Intacct Location entity selected here. Once configured, you can not change ' + brandingConfig.brandName + ' Organization or Location Entity.',
subLabel: 'To connect your ' + brandingConfig.brandName + ' and Sage Intacct account, follow the detailed instructions provided in the article to generate the credentials and establish a secure connection.'
subLabel: 'To connect your ' + brandingConfig.brandName + ' and Sage Intacct account, follow the detailed instructions provided in the article to generate the credentials and establish a secure connection.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Change 'account' to 'accounts' for grammatical correctness

In the text, 'To connect your Fyle and Sage Intacct account...', 'account' should be plural to match 'Fyle and Sage Intacct accounts'.

Apply this diff to fix the grammatical error:

-subLabel: 'To connect your ' + brandingConfig.brandName + ' and Sage Intacct account, follow the detailed instructions provided in the article to generate the credentials and establish a secure connection.',
+subLabel: 'To connect your ' + brandingConfig.brandName + ' and Sage Intacct accounts, follow the detailed instructions provided in the article to generate the credentials and establish a secure connection.',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
subLabel: 'To connect your ' + brandingConfig.brandName + ' and Sage Intacct account, follow the detailed instructions provided in the article to generate the credentials and establish a secure connection.',
subLabel: 'To connect your ' + brandingConfig.brandName + ' and Sage Intacct accounts, follow the detailed instructions provided in the article to generate the credentials and establish a secure connection.',

connectorInfoLabel: 'Please use the integration credentials you received via email. These are different from the ones you use to login to your Sage Intacct account.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Correct 'login' to 'log in' in the connectorInfoLabel

In the message, 'login' should be 'log in' when used as a verb.

Apply this diff to fix the grammatical error:

-connectorInfoLabel: 'Please use the integration credentials you received via email. These are different from the ones you use to login to your Sage Intacct account.'
+connectorInfoLabel: 'Please use the integration credentials you received via email. These are different from the ones you use to log in to your Sage Intacct account.'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
connectorInfoLabel: 'Please use the integration credentials you received via email. These are different from the ones you use to login to your Sage Intacct account.'
connectorInfoLabel: 'Please use the integration credentials you received via email. These are different from the ones you use to log in to your Sage Intacct account.'

},
exportSetting: {
stepName: 'Export Settings',
Expand Down
3 changes: 2 additions & 1 deletion src/app/core/models/branding/content-configuration.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ export type ContentConfiguration = {
connector: {
stepName: string;
subLabel: string;
locationSubLabel: string
locationSubLabel: string;
connectorInfoLabel: string;
},
exportSetting: {
stepName: string;
Expand Down
9 changes: 7 additions & 2 deletions src/app/shared/components/si/core/intacct-connector/intacct-connector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,16 @@
Incorrect {{brandingContent.intacct.common.password}}. Enter correct {{brandingContent.intacct.common.password}}.
</div>
</div>
<div *ngIf="brandingConfig.brandId === 'co'" class="tw-w-400-px tw-py-8-px tw-px-16-px tw-bg-bg-tertiary-lighter tw-border tw-border-separator tw-rounded-6-px">
<div *ngIf="brandingConfig.brandId === 'co'" class="tw-w-400-px tw-py-8-px tw-px-16-px tw-rounded-6-px tw-bg-bg-tertiary-lighter tw-border tw-border-separator">
<p class="tw-text-14-px tw-text-text-primary">
Make sure you’re entering your integration credentials. These should be different than your Sage Intacct credentials.
{{brandingContent.intacct.configuration.connector.connectorInfoLabel}}
</p>
</div>
<div *ngIf="brandingConfig.brandId !== 'co'" class="tw-w-400-px">
<app-configuration-info-label
[infoText]="brandingContent.intacct.configuration.connector.connectorInfoLabel">
</app-configuration-info-label>
</div>
</div>
</div>
</form>
Expand Down
Loading