feat: Qbd checkbox button creation #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces multiple enhancements across various components and configurations related to the QuickBooks Direct onboarding process. Key changes include the addition of new properties and methods in several components, updates to existing configuration files, and modifications to the routing logic. Notably, new components for onboarding prerequisites and data synchronization are introduced, along with updates to the ESLint configuration to disable a specific rule. Overall, these changes aim to improve user interactions and the configurability of the onboarding experience. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Onboarding as QbdDirectOnboardingConnectorComponent
participant Service as WorkspaceService
participant API as ApiService
User->>Onboarding: Initiate onboarding
Onboarding->>Service: Get current state
Service->>Onboarding: Return onboarding state
Onboarding->>User: Display onboarding steps
User->>Onboarding: Complete step
Onboarding->>Service: Update onboarding state
Service->>API: PATCH /update-state
API-->>Service: Confirmation
Service-->>Onboarding: State updated
Onboarding->>User: Show next step
Possibly related PRs
Suggested labels
Suggested reviewers
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
PR description must contain a link to a ClickUp (case-insensitive) |
ashwin1111
reviewed
Nov 4, 2024
| @@ -1,5 +1,10 @@ | |||
| import { FormGroup, Validators } from "@angular/forms"; | |||
|
|
|||
| export type checkBoxEmit = { | |||
| @@ -1,5 +1,10 @@ | |||
| import { FormGroup, Validators } from "@angular/forms"; | |||
|
|
|||
| export type checkBoxEmit = { | |||
| id: number; | |||
There was a problem hiding this comment.
better to add it to checkbox button component itself
| @@ -1 +1,10 @@ | |||
| <p>chechbox-button works!</p> | |||
There was a problem hiding this comment.
checkbox-button - fix typo
| @@ -1 +1,10 @@ | |||
| <p>chechbox-button works!</p> | |||
| <div [ngClass]="isCheckboxSelected ? 'checkedText' : 'unCheckedText'"> | |||
There was a problem hiding this comment.
checked-text, unchecked-text - kebab-case for css classes
|
|
||
| @Component({ | ||
| selector: 'app-chechbox-button', | ||
| standalone: true, | ||
| imports: [], | ||
| imports: [ButtonModule, CommonModule], | ||
| templateUrl: './chechbox-button.component.html', | ||
| styleUrl: './chechbox-button.component.scss' | ||
| }) | ||
| export class ChechboxButtonComponent { |
| templateUrl: './chechbox-button.component.html', | ||
| styleUrl: './chechbox-button.component.scss' | ||
| }) | ||
| export class ChechboxButtonComponent { | ||
|
|
||
| @Input() unCheckedText: string; |
There was a problem hiding this comment.
@Input({required: true}) unCheckedText: string;
| templateUrl: './chechbox-button.component.html', | ||
| styleUrl: './chechbox-button.component.scss' | ||
| }) | ||
| export class ChechboxButtonComponent { | ||
|
|
||
| @Input() unCheckedText: string; | ||
|
|
||
| @Input() checkedText: string; |
There was a problem hiding this comment.
let's add required everywhere where it's mandatory
|
PR description must contain a link to a ClickUp (case-insensitive) |
|
PR description must contain a link to a ClickUp (case-insensitive) |
|
ashwin1111
approved these changes
Nov 5, 2024
* feat: onboarding basic setup * feat: qbd direct onboarding landing page (#1056) * feat: qbd direct onboarding landing page * feat: qbd-direct-onboarding-pre-requisite implementation * PR comments fix * PR fix * updateWorkspaceOnboardingState service return type update * qbd direct logo update * feat: qbd-direct onboarding prerequisite UI implementation (#1058) * feat: qbd-direct-onboarding-pre-requisite implementation * styling changes * unit test fix * step footer contentt fix * pre requisite Ui updation * PR comments fix * PR comments fix * feat: Download qwd file UI changes (#1059) * feat: Download qwd file UI changes * download file Ui updation * download file Ui updation * download file Ui updation * download file Ui updation * feat: qbd connector setup UI changes (#1060) * feat: qbd connector setup UI changes * Merge branch qbd-direct-onboarding-download-file-UI into qbd-direct-step-connector-UI * feat: Qbd direct connection data sync UI changes (#1061) * feat: Qbd direct connection data sync UI changes * input made required * svg update * feat: qbd direct pre requisite ts changes (#1062) * feat: qbd direct pre requisite ts changes * feat: qbd direct pre requisite ts changes * feat: qbd direct connector download file ts changes (#1063) * feat: qbd direct connector download file ts changes * feat: qbd direct connector setup connector ts changes (#1064) * feat: qbd direct connector setup connector ts changes * feat: qbd direct connector data sync up ts changes (#1065) * PR comment fix * PR comment fix * Qbd direct connector data sync up ts (#1070) * feat: qbd direct pre requisite ts changes * feat: qbd direct pre requisite ts changes * feat: qbd direct connector download file ts changes * feat: qbd direct connector setup connector ts changes * feat: qbd direct connector data sync up ts changes * feat: QBD direct main connection page business logic (#1066) * feat: QBD direct main connection page business logic * onboarding connection ts changes * onboarding connection ts changes --------- Co-authored-by: ashwin1111 <[email protected]> --------- Co-authored-by: ashwin1111 <[email protected]> --------- Co-authored-by: ashwin1111 <[email protected]> --------- Co-authored-by: ashwin1111 <[email protected]> --------- Co-authored-by: ashwin1111 <[email protected]> --------- Co-authored-by: ashwin1111 <[email protected]>
ashwin1111
merged commit 024398f
into
qbd-direct-onboarding-phase-1
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: Qbd checkbox button creation
Clickup
https://app.clickup.com/t/86cwzcem1
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Style
Documentation