fix: intacct css fix #1015

DhaaraniCIT · 2024-10-11T06:34:49Z

Description

intacct css fix

Clickup

Please add link here

Summary by CodeRabbit

New Features
- Updated label for auto-creating vendors to "Auto-create employee as vendor" for clearer functionality.
- Enhanced styling for the "auto-create merchants" field in advanced settings for better visibility.
- Introduced theme-specific styles for buttons, dropdowns, checkboxes, and icons to improve user interface consistency.
Bug Fixes
- Refined hover and focus styles for improved user interaction across components.
Style
- Updated and added new styles for various components, ensuring a cohesive design across different themes.

coderabbitai · 2024-10-11T06:34:56Z

Walkthrough

The changes in this pull request involve modifications to the autoCreateVendorsLabel in the c1-contents-config.ts and fyle-contents-config.ts files, enhancing clarity regarding vendor creation in relation to employee data. Additionally, the HTML template for the intacct-advanced-settings.component.html has been updated with a new CSS class for improved styling. Extensive updates to the global styles in src/styles.scss focus on theme-specific designs, affecting various UI components across the application.

Changes

File Path	Change Summary
`src/app/branding/c1-contents-config.ts`	Updated `autoCreateVendorsLabel` from "Auto-create vendors" to "Auto-create employee as vendor."
`src/app/branding/fyle-contents-config.ts`	Updated `autoCreateVendorsLabel` from "Auto-Create Vendors" to "Auto-create employee as vendor." Several labels and descriptions enhanced for clarity.
`src/app/integrations/intacct/.../intacct-advanced-settings.component.html`	Added a CSS class for conditional rendering of the "auto-create merchants" field.
`src/styles.scss`	Extensive updates to theme-specific styles for buttons, dropdowns, checkboxes, and icons, including new icon URLs and standardized styles.
`src/app/integrations/qbo/.../qbo-advanced-settings.component.ts`	Enhanced logic for visibility of the auto-create vendors field in `isAutoCreateVendorsFieldVisible` method.

Possibly related PRs

test: Export Settings QBO #931: Enhancements to the QboExportSettingsComponent, potentially related to vendor settings.
qbo code prepend changes #958: Modifications to the QBOImportSettingWorkspaceGeneralSetting type, relevant to vendor settings.
feat: intacct code prepend fixes #965: Updates to the Intacct configuration, related to handling of settings.
chore: Intacct connector page info box for fyle theme #991: Updates to the c1-contents-config.ts file, directly relating to changes in the main PR.
test: intacct export settings init, save, and misc functions #1001: Focuses on testing initialization and saving functions of the IntacctExportSettingsComponent, potentially related to vendor settings.
test: intacct export settings watchers #1002: Enhances test coverage for the IntacctExportSettingsComponent, may include vendor-related tests.
test: intacct export settings edge cases and utility functions #1003: Adds tests for edge cases and utility functions in the IntacctExportSettingsComponent, related to vendor settings.
fix: intacct prepend code field fix #1011: Addresses logic for managing import code fields in the IntacctImportSettingsComponent, related to vendor settings.

Suggested reviewers

ashwin1111

🐇 In the meadow, changes bloom,
Styles and classes chase the gloom.
With buttons bright and dropdowns fair,
Conditional fields now dance in air.
A rabbit's cheer for themes so bright,
Hopping through code, a joyful sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-10-11T06:35:08Z

PR description must contain a link to a ClickUp (case-insensitive)

github-actions · 2024-10-11T06:36:44Z

PR description must contain a link to a ClickUp (case-insensitive)

DhaaraniCIT · 2024-10-11T07:34:16Z

github-actions · 2024-10-11T07:36:59Z

PR description must contain a link to a ClickUp (case-insensitive)

github-actions · 2024-10-11T07:40:19Z

PR description must contain a link to a ClickUp (case-insensitive)

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.ts (1)
158-158: LGTM! Consider extracting complex conditions for improved readability.

The additional condition for reimbursable_expenses_object is a logical improvement, ensuring the auto-create vendors field is only visible for relevant expense types (BILL or EXPENSE). This change aligns well with the method's purpose.

To enhance readability, consider extracting the complex conditions into separate methods or variables. For example:
private isValidEmployeeMapping(): boolean {
  return this.workspaceGeneralSettings.employee_field_mapping === EmployeeFieldMapping.VENDOR &&
         this.workspaceGeneralSettings.auto_map_employees !== null &&
         this.workspaceGeneralSettings.auto_map_employees !== AutoMapEmployeeOptions.EMPLOYEE_CODE;
}

private isValidReimbursableExpenseObject(): boolean {
  return this.workspaceGeneralSettings.reimbursable_expenses_object === QBOReimbursableExpensesObject.BILL ||
         this.workspaceGeneralSettings.reimbursable_expenses_object === QBOReimbursableExpensesObject.EXPENSE;
}

isAutoCreateVendorsFieldVisible(): boolean {
  return this.isValidEmployeeMapping() && this.isValidReimbursableExpenseObject();
}
This refactoring would make the method more readable and easier to maintain in the future.
src/app/branding/fyle-contents-config.ts (1)

291-291: Consider reviewing similar settings across all integrations

While the change to the autoCreateVendorsLabel for QuickBooks Online is an improvement, it might be beneficial to review similar settings across all integrations (NetSuite, Xero, Sage Intacct) to ensure consistent terminology and clarity. This could further enhance the overall user experience and maintain uniformity across different integration configurations.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a56b0c3 and 6366a48.

📒 Files selected for processing (3)

src/app/branding/c1-contents-config.ts (1 hunks)
src/app/branding/fyle-contents-config.ts (1 hunks)
src/app/integrations/qbo/qbo-shared/qbo-advanced-settings/qbo-advanced-settings.component.ts (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

src/app/branding/c1-contents-config.ts (1)

291-291: Improved clarity in vendor auto-creation label

The change from "Auto-create vendors" to "Auto-create employee as vendor" provides better specificity and clarity about the auto-creation functionality. This modification helps users understand that employees are being created as vendors in QuickBooks Online, which is valuable information for configuring the integration correctly.

src/app/branding/fyle-contents-config.ts (1)

291-291: Improved clarity in auto-create vendor label

The change from 'Auto-Create Vendors' to 'Auto-create employee as vendor' enhances the specificity of the label. This modification provides users with a clearer understanding of the functionality, explicitly stating that employees will be auto-created as vendors. This improvement in clarity aligns well with the overall goal of enhancing user guidance throughout the integration settings.

github-actions · 2024-10-11T08:07:52Z

PR description must contain a link to a ClickUp (case-insensitive)

fix: intacct css fix

a56b0c3

DhaaraniCIT requested a review from ashwin1111 October 11, 2024 06:34

github-actions bot added the size/XS Extra Small PR label Oct 11, 2024

ashwin1111 approved these changes Oct 11, 2024

View reviewed changes

QBO auto create vendor condition and content fix

6366a48

coderabbitai bot reviewed Oct 11, 2024

View reviewed changes

Merge branch 'master' into sage-intacct-css-fix

c42b39b

DhaaraniCIT merged commit d3c722a into master Oct 11, 2024
2 of 3 checks passed

This was referenced Oct 11, 2024

feat: Single credit line for Journal Entry #1017

Merged

fix: form value bug fixes #1022

Merged

This was referenced Nov 13, 2024

feat: onboarding basic setup #1055

Merged

feat: qbd direct onboarding landing page #1056

Merged

feat: Download qwd file UI changes #1059

Merged

feat: qbd-direct onboarding prerequisite UI implementation #1058

Merged

This was referenced Nov 22, 2024

fix: qbd direct advanced settings onboarding changes and content changes #1084

Merged

fix: text changes in business central configuration #1089

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: intacct css fix #1015

fix: intacct css fix #1015

DhaaraniCIT commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

DhaaraniCIT commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

coderabbitai bot left a comment

github-actions bot commented Oct 11, 2024

fix: intacct css fix #1015

fix: intacct css fix #1015

Conversation

DhaaraniCIT commented Oct 11, 2024 • edited by coderabbitai bot Loading

Description

Clickup

Summary by CodeRabbit

coderabbitai bot commented Oct 11, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

DhaaraniCIT commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2024

DhaaraniCIT commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 11, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)