QBD logo update (#898)

* QBD logo update * fix img
fylein · Aug 7, 2024 · 3f01c07 · 3f01c07
1 parent 24f0172
commit 3f01c07
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 166 deletions.
diff --git a/src/app/core/services/common/api.service.ts b/src/app/core/services/common/api.service.ts
@@ -28,10 +28,20 @@ export class ApiService {
   private handleError(error: HttpErrorResponse, httpMethod: string, url: string) {
     if (error.error instanceof ErrorEvent) {
       console.error('An error occurred:', error.error.message);
-    } else if (error.status >= 500) {
-      console.error(
-        `Backend returned code ${error.status}, url was: ${url} method was: ${httpMethod}, body was: ${JSON.stringify(error.error)}`
-      );
+    } else {
+      // Raise error only for non GET requests and 5xx errors (incase of GET)
+      let raiseError: boolean = false;
+      if (httpMethod !== 'GET') {
+        raiseError = true;
+      } else if (error.status >= 500) {
+        raiseError = true;
+      }
+
+      if (raiseError) {
+        console.error(
+          `Backend returned code ${error.status}, url was: ${url} method was: ${httpMethod}, body was: ${JSON.stringify(error.error)}`
+        );
+      }
     }
     return throwError(error);
   }

diff --git a/src/app/integrations/landing/landing.component.html b/src/app/integrations/landing/landing.component.html
@@ -41,7 +41,7 @@
                         </span>
                     </div>
                     <div *ngIf="exposeApps.QBD" class="landing--accounting-app tw-mr-20-px tw-mt-20-px" [ngClass]="{'tw-shadow-app-card': brandingConfig.brandId === 'fyle', 'tw-shadow-shadow-level-1': brandingConfig.brandId === 'co'}" (click)="openInAppIntegration(InAppIntegration.QBD)">
-                        <img src="assets/logos/quickbooks-desktop.svg" class="tw-mt-[-20px]" width="120px" height="60px" />
+                        <img src="assets/logos/quickbooks-logo.png" class="tw-mt-[-20px]" width="120px" height="60px" />
                         <span class="landing--accounting-app-name">
                             QuickBooks Desktop
                         </span>

diff --git a/src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.html b/src/app/integrations/qbd/qbd-main/qbd-dashboard/qbd-dashboard.component.html
@@ -66,7 +66,7 @@ <h4 class="tw-font-500">IIF file logs</h4>
                     <ng-template pTemplate="header">
                         <tr>
                             <th>Date and Time of Export</th>
-                            <th>Exported to QBD as</th>
+                            <th>Exported as</th>
                             <th>Expense Type</th>
                             <th>Download IIF File</th>
                         </tr>

diff --git a/src/app/integrations/qbd/qbd-onboarding/qbd-onboarding-landing/qbd-landing.component.html b/src/app/integrations/qbd/qbd-onboarding/qbd-onboarding-landing/qbd-landing.component.html
@@ -1,6 +1,6 @@
 <div>
     <div>
-        <app-landing-page-header [iconPath]="'assets/logos/quickbooks-desktop.svg'" [appName]="'QuickBooks Desktop'" [appDescription]="'Generate IIF file to export expenses from ' + brandingConfig.brandName + ' to QuickBooks Desktop'" [isLoading]="isLoading" [isIntegrationSetupInProgress]="isQBDSetupInProgress" [isIntegrationConnected]="isQBDConnected" [postConnectionRoute]="'qbd/onboarding/export_settings'" [buttonText]="'Start'"></app-landing-page-header>
+        <app-landing-page-header [iconPath]="'assets/logos/qbo.png'" [appName]="'QuickBooks Desktop'" [appDescription]="'Generate IIF file to export expenses from ' + brandingConfig.brandName + ' to QuickBooks Desktop'" [isLoading]="isLoading" [isIntegrationSetupInProgress]="isQBDSetupInProgress" [isIntegrationConnected]="isQBDConnected" [postConnectionRoute]="'qbd/onboarding/export_settings'" [buttonText]="'Start'" [logoStyleClasses]="'tw-p-16-px'"></app-landing-page-header>
     </div>
     <div>
         <app-landing-page-body [headerText]="'Configure the integration to generate custom IIF file to export expenses from ' + brandingConfig.brandName + ' to QuickBooks Desktop.'" [svgPath]="'assets/flow-charts/qbd-flow-chart.svg'" [redirectLink]="brandingKbArticles.topLevelArticles.QBD" [appName]="appName"></app-landing-page-body>