jvm options in ${name}.l4j.ini are not recognized on macOS

[kia]

I'm submitting a…

• bug report
• feature request
• other

Short description:
the jvm options in ${name}.l4j.ini are not recognized on macOS:

Steps to reproduce the issue/enhancement:

1. [First Step]
   take this source code as an example

java-packager-example.zip

2. unzip and run mvn clean package
3. start the created application:
   target/deploy/java-packager-example/java-packager-example

What is the expected behavior?
output:
hello.world: HelloWorld

What is the current behavior?
on Linux as above but on Mac

hello.world: null

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement?
see above

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

• JavaPackager version: 1.7.2
• OS version: macOS 10.15.7
• JDK version: 19.0.2
• Build tool:
  • Maven
  • Gradle

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

[fvarrui]

Hi @kia!
I think I just found the error.

The universalJavaApplicationStub startup script reads the JVMOptionsFile key from the Info.plist file:

JavaPackager/src/main/resources/mac/Info.plist.vtl

Lines 114 to 115 in fa1ca46

	<key>JVMOptionsFile</key>
	<string>$APP_PACKAGE/Contents/Resources/${info.name}.l4j.ini</string>

and stores the value in a variable of the same name ($JVMOptionsFile):

JavaPackager/src/main/resources/mac/universalJavaApplicationStub.sh

Lines 247 to 248 in fa1ca46

	# read options file name
	JVMOptionsFile=$(plist_get_java ':JVMOptionsFile')

As can be seen here, the variable $APP_PACKAGE is used, which inside the universalJavaApplicationStub is given the value /full/path/to/My.app (full path to the application directory), assuming that My.app is our application.

The problem is that the $APP_PACKAGE variable is not expanded into the $JVMOptionsFile variable, so it never reads the contents of the l4j.ini file, as it doesn't exist for the script.

# read options file name 
JVMOptionsFile=$(plist_get_java ':JVMOptionsFile') 
JVMOptionsFile=$(eval echo "${JVMOptionsFile}") # I missed this line

I hope I have explained myself! 😅

I am working on it!!!

[fvarrui]

Ok, just fixed in 1.7.3-20230601.235908-6 (as this is a specific SNAPSHOT version you should read this).

If it works fine for you, this fix will be released in v1.7.3.

[kia]

Hi @fvarrui ,
Thanks for this really quick fix!
I will check it and let you know about the result.

[kia]

Hi @fvarrui ,
The fix worked! Thanks a lot.

best,
Kia

[fvarrui]

Great 😃

[fvarrui]

Merged into devel branch, ready to be deployed

[kia]

Hi @fvarrui ,

when would the next release (1.7.3) be available?

thanks,
@kia

[fvarrui]

1.7.3 released to Maven Central

[kia]

Hi @fvarrui
There is now a new issue. The ${name}-${version}-runnable.jar is not found in deployment directory. In the deployement directory i find ${name}.jar without version and 'runnable'.

Am i missing some configuration details that i have to consider in the new Version?

The very last step during packaging seems to rename the build artifact jar file.
This is the message:

Concatenating files [/target/deploy/linux/assets/startup.sh,/target/deploy/linux/name-version-runnable.jar] into file [/target/deploy/linux/<name>.jar]

best,
Kia

[fvarrui]

Ok, lets open a new issue for this, and I'll try to reproduce this issue in order to find out what's happening.