Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History and diff on commit approval page #231

Open
gavinwahl opened this issue Jul 10, 2014 · 0 comments
Open

History and diff on commit approval page #231

gavinwahl opened this issue Jul 10, 2014 · 0 comments

Comments

@gavinwahl
Copy link
Member

On the review queue commit approval page, It'd be nice to see the diff for the commit we're approving. Also maybe the history of the page.

  • Should the diff be between the commit and its parent, or between the commit and the current version of the page?
  • Pages can add multiple preview buttons (for multiple languages, for example). I guess we'd have to show the diff for each one? VersionTrackerMixin.get_diff_urls has this logic, but I'm not sure how to share that code with VersionCommitAdmin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavinwahl