Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added .bounding_box and refactored .largest_dimension #228

Merged
merged 8 commits into from
Mar 31, 2022
Merged

added .bounding_box and refactored .largest_dimension #228

merged 8 commits into from
Mar 31, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

tidies up the utils import statements a little bit and moves the largest_dimension function to the utils.

this will allow largest_dimension to be called during the construction of solids to help find the height and radius when making a cutting wedge

@shimwell shimwell changed the title moved largest dimention added .bounding_box and refactored .largest_dimension Mar 31, 2022
shimwell
shimwell commented Mar 31, 2022
View reviewed changes
shimwell
shimwell commented Mar 31, 2022
View reviewed changes
shimwell
shimwell commented Mar 31, 2022
View reviewed changes
shimwell
shimwell commented Mar 31, 2022
View reviewed changes
shimwell
shimwell commented Mar 31, 2022
View reviewed changes
shimwell
shimwell commented Mar 31, 2022
View reviewed changes
@shimwell shimwell merged commit e1277fd into develop Mar 31, 2022
@shimwell shimwell deleted the utils_tidy_up branch March 31, 2022 21:55
@shimwell shimwell mentioned this pull request Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shimwell