Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neg tri tidy up #210

Merged
merged 7 commits into from
Mar 14, 2022
Merged

Neg tri tidy up #210

merged 7 commits into from
Mar 14, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Makes some pep changes using flake8 to the code

Types of changes

What types of changes does your code introduce to the Paramak?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #210 (317b67d) into develop (29301a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 317b67d differs from pull request most recent head d02bb7f. Consider uploading reports for the commit d02bb7f to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #210   +/-   ##
========================================
  Coverage    96.19%   96.19%           
========================================
  Files           79       79           
  Lines         5278     5263   -15     
========================================
- Hits          5077     5063   -14     
+ Misses         201      200    -1     
Impacted Files Coverage Δ
paramak/parametric_components/tf_coil_casing.py 100.00% <ø> (ø)
...ramak/parametric_components/toroidal_field_coil.py 100.00% <ø> (ø)
...k/parametric_components/vacuum_vessel_inner_leg.py 89.06% <ø> (-0.17%) ⬇️
paramak/shape.py 95.21% <ø> (-0.03%) ⬇️
...ric_components/blanket_constant_thickness_arc_v.py 100.00% <100.00%> (ø)
paramak/parametric_components/blanket_fp.py 100.00% <100.00%> (ø)
...ak/parametric_components/center_column_circular.py 100.00% <100.00%> (ø)
paramak/parametric_components/extrude_rectangle.py 100.00% <100.00%> (ø)
...ak/parametric_components/inboard_firstwall_fccs.py 100.00% <100.00%> (ø)
...ramak/parametric_components/poloidal_field_coil.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29301a4...d02bb7f. Read the comment docs.

@shimwell shimwell merged commit b778c83 into develop Mar 14, 2022
@shimwell shimwell deleted the neg_tri_tidy_up branch March 16, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant