Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for cq 2.2 #176

Merged
merged 7 commits into from
Jan 31, 2022
Merged

Updates for cq 2.2 #176

merged 7 commits into from
Jan 31, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Some nice work done by Liam on preparing for the API changes expected in CQ 2.2

I can work on this branch to add full support for the CQ master branch. After some reading I looks like just two more changes are needed.

This has become more important for me recently as it is a blocking issue on upgrading the training material

Todo

  • Jon to get shape.volumes working
  • Jon to get shape.areas working

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

@shimwell shimwell self-assigned this Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #176 (d05d510) into develop (be93702) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d05d510 differs from pull request most recent head 92c9dcc. Consider uploading reports for the commit 92c9dcc to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #176   +/-   ##
========================================
  Coverage    97.67%   97.68%           
========================================
  Files           77       77           
  Lines         4816     4830   +14     
========================================
+ Hits          4704     4718   +14     
  Misses         112      112           
Impacted Files Coverage Δ
...tric_components/toroidal_field_coil_coat_hanger.py 100.00% <100.00%> (ø)
...metric_components/toroidal_field_coil_rectangle.py 100.00% <100.00%> (ø)
...ic_components/toroidal_field_coil_round_corners.py 93.29% <100.00%> (+0.03%) ⬆️
paramak/parametric_shapes/extruded_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/extruded_mixed_shape.py 100.00% <100.00%> (ø)
paramak/utils.py 94.16% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be93702...92c9dcc. Read the comment docs.

@shimwell
Copy link
Member Author

looks like the pep formatting has changed all the ** to **

@shimwell shimwell merged commit f992bf2 into develop Jan 31, 2022
@shimwell shimwell deleted the updates_for_cq_2.2 branch February 11, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants