-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fix #168
Docs fix #168
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #168 +/- ##
========================================
Coverage 97.67% 97.67%
========================================
Files 77 77
Lines 4824 4824
========================================
Hits 4712 4712
Misses 112 112 Continue to review full report at Codecov.
|
Nice, pinning pyparsing to 2.4.7 sounds like a good plan, I guess this means we can use CQ 2.1 and avoid those tessellation errors. Looking forward to seeing if the docs work out |
Congrats @LiamPattinson looks like the ~ solved it. Shall I merge this in |
Amazing! I'd almost lost hope on solving this one. Since making changes to setup.cfg, I'm not sure if the changes to environment.yml are needed anymore. Do you think it's worth reverting environment.yml, or should we just merge as-is? |
I would merge as is and if further tinkering is beneficial perhaps best on another PR. Mission complete for this one 🎉 |
@LiamPattinson I just noticed a similar method on CadQuery https://github.com/CadQuery/cadquery/blob/e0b4c942ab382cac38bb462b9d878f8863a88ae7/environment.yml#L10 |
Proposed changes
Rather than requiring an update to CadQuery's master version, which diverges quite significantly from v2.1, this pull request keeps CadQuery at 2.1 but tries to fix the python version and pyparsing version for the readthedocs build.
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.