Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass tag as paramak version when building docker on release #166

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

ZedThree
Copy link
Contributor

Proposed changes

Pass tag into docker build when building containers on release

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ZedThree
Copy link
Contributor Author

Sorry @shimwell, I got sidetracked and didn't manage to get this in earlier! This is a missing bit of the docker workflow: actually setting the version from the tag on Github releases.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #166 (71b12bc) into develop (983daa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #166   +/-   ##
========================================
  Coverage    97.67%   97.67%           
========================================
  Files           77       77           
  Lines         4824     4824           
========================================
  Hits          4712     4712           
  Misses         112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983daa0...71b12bc. Read the comment docs.

@shimwell
Copy link
Member

Thanks for this, not sure how I missed it.

@shimwell
Copy link
Member

I can merge this tonight unless there are any objections

@shimwell shimwell merged commit 26a07d0 into fusion-energy:develop Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants