Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding export h5m using brep gmsh method #157

Merged
merged 37 commits into from
Feb 6, 2022

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jan 23, 2022

Proposed changes

This PR allows the paramak to export h5m files for reactors and shapes.

This is achieved by using Gmsh and Brep files and a couple of recently create packages brep_part_finder and ```brep_to_h5m``

The workflow is nearly there but additional work is needed to get the conda install working in all cases. This is because Moab is needed for the h5m file creation but it is not currently available on with the conda install on windows. Therefore different conda instructions will be needed for windows and linux/mac.

The installation instructions will also need updating, at this point the pip install option will need to include extra conda installs for moab and gmsh.

This should only be merged once the next version of cadquery has been released. This is because features from the master branch of CQ are needed.

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the base branch from develop to updates_for_cq_2.2 January 28, 2022 22:09
@shimwell shimwell changed the base branch from updates_for_cq_2.2 to develop February 2, 2022 23:41
@shimwell shimwell changed the base branch from develop to develop_temp February 6, 2022 21:21
@shimwell shimwell merged commit 03bf9da into develop_temp Feb 6, 2022
@shimwell shimwell deleted the adding_export_h5m_using_brep_gmsh_method branch February 6, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant