-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding export h5m using brep gmsh method #157
Merged
shimwell
merged 37 commits into
develop_temp
from
adding_export_h5m_using_brep_gmsh_method
Feb 6, 2022
Merged
Adding export h5m using brep gmsh method #157
shimwell
merged 37 commits into
develop_temp
from
adding_export_h5m_using_brep_gmsh_method
Feb 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:fusion-energy/paramak into adding_export_h5m_using_brep_gmsh_method
…:fusion-energy/paramak into adding_export_h5m_using_brep_gmsh_method
shimwell
commented
Jan 28, 2022
shimwell
commented
Jan 31, 2022
shimwell
commented
Jan 31, 2022
…:fusion-energy/paramak into adding_export_h5m_using_brep_gmsh_method
shimwell
commented
Feb 6, 2022
shimwell
commented
Feb 6, 2022
shimwell
commented
Feb 6, 2022
shimwell
commented
Feb 6, 2022
shimwell
commented
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR allows the paramak to export h5m files for reactors and shapes.
This is achieved by using Gmsh and Brep files and a couple of recently create packages
brep_part_finder
and ```brep_to_h5m``The workflow is nearly there but additional work is needed to get the conda install working in all cases. This is because Moab is needed for the h5m file creation but it is not currently available on with the conda install on windows. Therefore different conda instructions will be needed for windows and linux/mac.
The installation instructions will also need updating, at this point the pip install option will need to include extra conda installs for moab and gmsh.
This should only be merged once the next version of cadquery has been released. This is because features from the master branch of CQ are needed.
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.