Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing auto pep8 #126

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Replacing auto pep8 #126

merged 3 commits into from
Nov 3, 2021

Conversation

shimwell
Copy link
Member

Proposed changes

improved method of pep8 formatting

can be duplicated locally
popular formatter (black)
skips CI on new commits

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the base branch from main to develop October 31, 2021 14:42
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #126 (15bcbce) into develop (4f720ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #126   +/-   ##
========================================
  Coverage    97.73%   97.73%           
========================================
  Files           76       76           
  Lines         4689     4689           
========================================
  Hits          4583     4583           
  Misses         106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f720ec...15bcbce. Read the comment docs.

@shimwell shimwell merged commit 67bade1 into develop Nov 3, 2021
@shimwell shimwell deleted the replacing_auto_pep8 branch November 3, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant