Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check for name none #115

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Adding check for name none #115

merged 5 commits into from
Oct 5, 2021

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Oct 4, 2021

Proposed changes

stp files were being exported with the name as None and saved as None.stp.

This PR adds a check when exporting stp and slt files using the Shape.name. Checks that the Shape.name is not None.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #115 (c21b589) into develop (1f7914d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #115   +/-   ##
========================================
  Coverage    96.87%   96.88%           
========================================
  Files           76       76           
  Lines         4738     4744    +6     
========================================
+ Hits          4590     4596    +6     
  Misses         148      148           
Impacted Files Coverage Δ
paramak/reactor.py 86.25% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7914d...c21b589. Read the comment docs.

@shimwell shimwell merged commit da78035 into develop Oct 5, 2021
@shimwell shimwell deleted the adding_check_for_name_none branch October 5, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant