Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove native methods not used by jansi #208

Closed
gnodet opened this issue Apr 28, 2021 · 2 comments · May be fixed by gnodet/jansi#1
Closed

Remove native methods not used by jansi #208

gnodet opened this issue Apr 28, 2021 · 2 comments · May be fixed by gnodet/jansi#1
Milestone
2.4.0

Comments

@gnodet
Copy link
Member

gnodet commented Apr 28, 2021 •
edited
Loading

Jansi 2.3.0 introduced 2 native methods (setenv and chdir) which are used by https://github.com/mvndaemon/mvnd but not jansi, so they should be removed once apache/maven-mvnd#400 has been released.
@davsclaus
Copy link
Member

@gnodet has that mvnd been released? If so then this ticket can be implemented

@gnodet
Copy link
Member Author

gnodet commented Oct 4, 2021

Yes, definitely, I'll get rid of those two methods.

@gnodet gnodet closed this as completed in ae20846 Oct 4, 2021
@gnodet gnodet added this to the 2.4.0 milestone Oct 11, 2021
@gnodet gnodet mentioned this issue Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Fix wrong output encoding on Windows with JDK >= 19 (fixes #247) gnodet/jansi
2 participants
@gnodet @davsclaus