Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use of jquery from Django Address #139

Open
banagale opened this issue Nov 20, 2020 · 4 comments
Open

Deprecate use of jquery from Django Address #139

banagale opened this issue Nov 20, 2020 · 4 comments
Assignees
Labels
Question Questions about django-address
Milestone

Comments

@banagale
Copy link
Collaborator

I've come to believe jquery should be eliminated from new software releases where possible.

django-address uses jquery in the javascript functions that perform the auto complete function, (jquery.geocomplete.js).

Does anyone have any strong feelings about keeping jquery in for any reason? Any chance someone is interested in taking on building a PR that finds a replacement or refactors the above library into pure ES 2015 plus vanilla JS?

@banagale banagale added the Question Questions about django-address label Nov 20, 2020
@abmohan
Copy link

abmohan commented Feb 13, 2021

Good call, @banagale. Vanilla JS should be able to handle most of what's going on here. I wouldn't mind taking a stab at it.

@banagale
Copy link
Collaborator Author

Okay @abmohan Please do post if you begin work on this / any status updates you're able to offer. I'll assign this to you for now, if it looks like it can't get done just let me know.

@banagale
Copy link
Collaborator Author

banagale commented May 17, 2021

Google offers its own Places Autocomplete Javascript library that handles the autocomplete feature on text inputs. 

Note, the packaged jQuery plugin was based off Google's geo-autocomplete which refers people to use the updated Google Maps V3 API instead.

Should be possible to update AddressWidget to excise jquery.

@furious-luke
Copy link
Owner

Hey @banagale! I've got some time at the moment, I'll take a peek at how hard it might be to get Google's autocomplete library used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Questions about django-address
Projects
None yet
Development

No branches or pull requests

3 participants