-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate use of jquery from Django Address #139
Comments
Good call, @banagale. Vanilla JS should be able to handle most of what's going on here. I wouldn't mind taking a stab at it. |
Okay @abmohan Please do post if you begin work on this / any status updates you're able to offer. I'll assign this to you for now, if it looks like it can't get done just let me know. |
Google offers its own Places Autocomplete Javascript library that handles the autocomplete feature on text inputs. Note, the packaged jQuery plugin was based off Google's Should be possible to update |
Hey @banagale! I've got some time at the moment, I'll take a peek at how hard it might be to get Google's autocomplete library used here. |
I've come to believe jquery should be eliminated from new software releases where possible.
django-address
uses jquery in the javascript functions that perform the auto complete function, (jquery.geocomplete.js).Does anyone have any strong feelings about keeping jquery in for any reason? Any chance someone is interested in taking on building a PR that finds a replacement or refactors the above library into pure ES 2015 plus vanilla JS?
The text was updated successfully, but these errors were encountered: