Don't reopen the store

[runspired]

this reopen is largely unnecesssary as it is, just adding to the class directly would work though even better would be to keep these as utils only.

[fsmanuel]

@runspired thanks for opening the issue. I'll look into it.

[fsmanuel]

@runspired you are talking about this, right?

ember-local-storage/addon/initializers/local-storage-adapter.js

Lines 7 to 19 in aa1f837

	export function initialize() {
	if (!Store.prototype._emberLocalStoragePatched) {
	Store.reopen({
	_emberLocalStoragePatched: true,
	importData: function (json, options) {
	return importData(this, json, options);
	},
	exportData: function (types, options) {
	return exportData(this, types, options);
	},
	});
	}
	}

I was already planning to provide it as utility functions. So I'll deprecate it and remove it in a future version.

[mwpastore]

I'm getting the following error after doing an ember-cli-update to 4.12 updating to ember-data 4.12:

local-storage-adapter.js:11
Uncaught TypeError: _emberData.default.Store.reopen is not a function
    at Object.initialize (local-storage-adapter.js:11:1)
    at index.js:130:1
    at Vertices.each (dag-map.js:192:1)
    at Vertices.walk (dag-map.js:121:1)
    at DAG.each (dag-map.js:66:1)
    at DAG.topsort (dag-map.js:72:1)
    at App._runInitializer (index.js:154:1)
    at App.runInitializers (index.js:128:1)
    at App._bootSync (index.js:489:1)
    at App.domReady (index.js:390:1)

[fsmanuel]

@runspired can you tell me which version of ember data removed the Store.reopen? From the failing tests I would say it's 4.12 is this correct?

[fsmanuel]

Released in v2.0.5

[runspired]

From the failing tests I would say it's 4.12 is this correct?

Yes. We're going to bring it back (for now) but glad usage here is removed.

[fsmanuel]

@runspired Thanks for the confirmation! I'll have to get more familiar with the changes in ember data and how to utilize them here. From what I saw it looks like a lot of work with great results. Thanks for working so hard on ember data!