Replace assert.equal by assert.strictEqual

funkensturm · May 14, 2023 · c21d5c0 · c21d5c0
1 parent 5dd2400
commit c21d5c0
Show file tree

Hide file tree

Showing 11 changed files with 133 additions and 112 deletions.
diff --git a/README.md b/README.md
@@ -524,7 +524,7 @@ module('basic acceptance test', function(hooks) {
 
   test('can visit /', async function(assert) {
     await visit('/');
-    assert.equal(currentURL(), '/');
+    assert.strictEqual(currentURL(), '/');
   });
 });
 

diff --git a/tests/helpers/storage.js b/tests/helpers/storage.js
@@ -1,6 +1,6 @@
 function storageEqual(assert, actual, expected, message) {
   actual = actual ? JSON.parse(actual) : undefined;
-  assert.equal(actual, expected, message);
+  assert.strictEqual(actual, expected, message);
 }
 
 function storageDeepEqual(assert, actual, expected, message) {

diff --git a/tests/unit/array-test.js b/tests/unit/array-test.js
@@ -39,8 +39,8 @@ module('array - likes', function (hooks) {
   test('it has correct defaults', function (assert) {
     assert.expect(3);
 
-    assert.equal(get(subject, 'anonymousLikes._storageType'), 'local');
-    assert.equal(
+    assert.strictEqual(get(subject, 'anonymousLikes._storageType'), 'local');
+    assert.strictEqual(
       get(subject, 'anonymousLikes._storageKey'),
       'storage:anonymous-likes'
     );
@@ -129,7 +129,7 @@ module('array - likes', function (hooks) {
     run(function () {
       get(subject, 'postLikes').clear();
     });
-    assert.equal(window.localStorage['storage:post-likes'], undefined);
+    assert.strictEqual(window.localStorage['storage:post-likes'], undefined);
   });
 
   test('after .clear() the array works as expected', function (assert) {
@@ -145,7 +145,7 @@ module('array - likes', function (hooks) {
     run(function () {
       get(subject, 'postLikes').clear();
     });
-    assert.equal(window.localStorage['storage:post-likes'], undefined);
+    assert.strictEqual(window.localStorage['storage:post-likes'], undefined);
 
     run(function () {
       get(subject, 'postLikes').addObject('martin');

diff --git a/tests/unit/helpers/import-export-test.js b/tests/unit/helpers/import-export-test.js
@@ -35,8 +35,8 @@ module('Unit | Helpers | import/export', function (hooks) {
         });
       })
       .then(function (data) {
-        assert.equal(get(data.posts, 'length'), 2);
-        assert.equal(get(data.comments, 'length'), 3);
+        assert.strictEqual(get(data.posts, 'length'), 2);
+        assert.strictEqual(get(data.comments, 'length'), 3);
       });
   });
 
@@ -60,8 +60,8 @@ module('Unit | Helpers | import/export', function (hooks) {
         });
       })
       .then(function (data) {
-        assert.equal(get(data.posts, 'length'), 2);
-        assert.equal(get(data.comments, 'length'), 3);
+        assert.strictEqual(get(data.posts, 'length'), 2);
+        assert.strictEqual(get(data.comments, 'length'), 3);
       });
   });
 
@@ -84,13 +84,13 @@ module('Unit | Helpers | import/export', function (hooks) {
         });
       })
       .then(function (data) {
-        assert.equal(get(data.posts, 'length'), 2);
-        assert.equal(get(data.comments, 'length'), 3);
-        assert.equal(
+        assert.strictEqual(get(data.posts, 'length'), 2);
+        assert.strictEqual(get(data.comments, 'length'), 3);
+        assert.strictEqual(
           JSON.parse(window.localStorage['index-comments']).length,
           3
         );
-        assert.equal(
+        assert.strictEqual(
           JSON.parse(window.sessionStorage['index-posts']).length,
           2
         );
@@ -117,7 +117,7 @@ module('Unit | Helpers | import/export', function (hooks) {
         return exportData(store, ['posts', 'comments'], { json: false });
       })
       .then(function (data) {
-        assert.equal(data.data.length, 5);
+        assert.strictEqual(data.data.length, 5);
       });
   });
 
@@ -142,7 +142,7 @@ module('Unit | Helpers | import/export', function (hooks) {
         return exportData(store, ['posts', 'comments'], { json: false });
       })
       .then(function (data) {
-        assert.equal(data.data.length, 5);
+        assert.strictEqual(data.data.length, 5);
       });
   });
 });
diff --git a/tests/unit/models/blog/post-test.js b/tests/unit/models/blog/post-test.js
@@ -18,7 +18,7 @@ module('Unit | Model | blog/post', function (hooks) {
 
     let posts = store.findAll('blog/post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store.createRecord('blog/post', { name: 'Super Name' }).save();
@@ -27,7 +27,7 @@ module('Unit | Model | blog/post', function (hooks) {
     });
 
     store.findAll('blog/post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 3);
+      assert.strictEqual(get(posts, 'length'), 3);
       done();
     });
   });
@@ -39,7 +39,7 @@ module('Unit | Model | blog/post', function (hooks) {
 
     let posts = store.findAll('blog/post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store.push({
@@ -59,7 +59,7 @@ module('Unit | Model | blog/post', function (hooks) {
     });
 
     store.findAll('blog/post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 2);
+      assert.strictEqual(get(posts, 'length'), 2);
       done();
     });
   });
@@ -81,8 +81,11 @@ module('Unit | Model | blog/post', function (hooks) {
 
     run(function () {
       store.findRecord('blog/post', get(newPost, 'id')).then(function (post) {
-        assert.equal(get(post, 'id'), get(newPost, 'id'));
-        assert.equal(get(post, 'name'), 'Ember.js: 10 most common mistakes');
+        assert.strictEqual(get(post, 'id'), get(newPost, 'id'));
+        assert.strictEqual(
+          get(post, 'name'),
+          'Ember.js: 10 most common mistakes'
+        );
         done();
       });
     });
@@ -94,7 +97,7 @@ module('Unit | Model | blog/post', function (hooks) {
     const store = this.owner.lookup('service:store');
     let posts = store.findAll('blog/post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store
@@ -111,7 +114,7 @@ module('Unit | Model | blog/post', function (hooks) {
     });
 
     store.findAll('blog/post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 2);
+      assert.strictEqual(get(posts, 'length'), 2);
       done();
     });
   });
@@ -122,7 +125,7 @@ module('Unit | Model | blog/post', function (hooks) {
     const store = this.owner.lookup('service:store');
     let posts = store.findAll('blog/post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store
@@ -145,13 +148,13 @@ module('Unit | Model | blog/post', function (hooks) {
     });
 
     store.findAll('blog/post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 3);
+      assert.strictEqual(get(posts, 'length'), 3);
     });
 
     store
       .queryRecord('blog/post', { filter: { name: 'Super Name' } })
       .then(function (post) {
-        assert.equal(get(post, 'name'), 'Super Name');
+        assert.strictEqual(get(post, 'name'), 'Super Name');
         done();
       });
   });

diff --git a/tests/unit/models/post-test.js b/tests/unit/models/post-test.js
@@ -34,7 +34,7 @@ module('Unit | Model | post', function (hooks) {
 
     let posts = store.findAll('post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store.createRecord('post', { name: 'Super Name' }).save();
@@ -43,7 +43,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 3);
+      assert.strictEqual(get(posts, 'length'), 3);
       done();
     });
   });
@@ -55,7 +55,7 @@ module('Unit | Model | post', function (hooks) {
 
     let posts = store.findAll('post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store.push({
@@ -75,7 +75,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 2);
+      assert.strictEqual(get(posts, 'length'), 2);
       done();
     });
   });
@@ -97,8 +97,11 @@ module('Unit | Model | post', function (hooks) {
 
     run(function () {
       store.findRecord('post', get(newPost, 'id')).then(function (post) {
-        assert.equal(get(post, 'id'), get(newPost, 'id'));
-        assert.equal(get(post, 'name'), 'Ember.js: 10 most common mistakes');
+        assert.strictEqual(get(post, 'id'), get(newPost, 'id'));
+        assert.strictEqual(
+          get(post, 'name'),
+          'Ember.js: 10 most common mistakes'
+        );
         done();
       });
     });
@@ -110,7 +113,7 @@ module('Unit | Model | post', function (hooks) {
     const store = this.owner.lookup('service:store');
     let posts = store.findAll('post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store
@@ -127,7 +130,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 2);
+      assert.strictEqual(get(posts, 'length'), 2);
       done();
     });
   });
@@ -138,7 +141,7 @@ module('Unit | Model | post', function (hooks) {
     const store = this.owner.lookup('service:store');
     let posts = store.findAll('post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     let paul;
 
@@ -173,13 +176,13 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 3);
+      assert.strictEqual(get(posts, 'length'), 3);
     });
 
     store
       .queryRecord('post', { filter: { name: 'Super Name' } })
       .then(function (post) {
-        assert.equal(get(post, 'name'), 'Super Name');
+        assert.strictEqual(get(post, 'name'), 'Super Name');
         done();
       });
   });
@@ -190,12 +193,12 @@ module('Unit | Model | post', function (hooks) {
     const store = this.owner.lookup('service:store');
     let posts = store.findAll('post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     store
       .queryRecord('post', { filter: { name: 'Super Name' } })
       .then(function (post) {
-        assert.equal(post, null);
+        assert.strictEqual(post, null);
 
         done();
       })
@@ -222,7 +225,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 1);
+      assert.strictEqual(get(posts, 'length'), 1);
       done();
     });
   });
@@ -240,7 +243,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 1);
+      assert.strictEqual(get(posts, 'length'), 1);
       done();
     });
   });
@@ -259,7 +262,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 1);
+      assert.strictEqual(get(posts, 'length'), 1);
       done();
     });
   });
@@ -274,7 +277,7 @@ module('Unit | Model | post', function (hooks) {
 
     let posts = store.findAll('post');
 
-    assert.equal(get(posts, 'length'), 0);
+    assert.strictEqual(get(posts, 'length'), 0);
 
     run(function () {
       store.push({
@@ -294,7 +297,7 @@ module('Unit | Model | post', function (hooks) {
     });
 
     store.findAll('post').then(function (posts) {
-      assert.equal(get(posts, 'length'), 2);
+      assert.strictEqual(get(posts, 'length'), 2);
       done();
     });
   });
@@ -319,8 +322,11 @@ module('Unit | Model | post', function (hooks) {
 
     run(function () {
       store.findRecord('post', get(newPost, 'id')).then(function (post) {
-        assert.equal(get(post, 'id'), get(newPost, 'id'));
-        assert.equal(get(post, 'name'), 'Ember.js: 10 most common mistakes');
+        assert.strictEqual(get(post, 'id'), get(newPost, 'id'));
+        assert.strictEqual(
+          get(post, 'name'),
+          'Ember.js: 10 most common mistakes'
+        );
         done();
       });
     });