Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: QWidget deleted error for results list when closing/opening viewer from notebook #105

Open
cmalinmayor opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cmalinmayor
Copy link
Collaborator

TracksViewer.tracks_list is the actual QWidget object, not just a list of tracks. This makes it fragile when closing/reopening the same viewer, and thus the same TracksViewer object (because it is a Singleton, it will try to re-use the original TracksList).

One solution is to just save the list of tracks in the TracksViewer, and remake the widget from the list each time. This matches our other widgets, and is better than the current state.

@cmalinmayor cmalinmayor added the bug Something isn't working label Nov 4, 2024
@cmalinmayor cmalinmayor added this to the Technical debt milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants