Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selenium-python-helium integration #1

Closed
petrisorionel opened this issue Apr 20, 2021 · 6 comments
Closed

selenium-python-helium integration #1

petrisorionel opened this issue Apr 20, 2021 · 6 comments

Comments

@petrisorionel
Copy link

petrisorionel commented Apr 20, 2021

selenium-python-helium

It will be great if we can integrate selenium-python-helium https://github.com/mherrmann/selenium-python-helium in this project.

https://selenium-python-helium.readthedocs.io/en/latest/api.html

I try with selenium https://pypi.org/project/selenium/ library and works fine, all screenshots are saved in screenshot directory.

With Helium screenshots are not saved.

@fungaegis
Copy link
Owner

I've added support for helium, but I didn't know about helium before, and I didn't use helium project. I've tested it with a simple example. I hope you can use it to see if it works normally.
Update to the latest version, looking forward to your feedback

@petrisorionel
Copy link
Author

Hi @fungaegis , you already made the changes? I'm asking because last commit is 2 months old.

@fungaegis
Copy link
Owner

I just forgot to push to GitHub. Now I've pushed. Pypi has already been updated( https://pypi.org/project/pytest-failed-screenshot/ )You can update to the latest through pip

@petrisorionel
Copy link
Author

Hi @fungaegis just tested, everything works as expected. I would like to contribute to this project, if you agree with that.

@fungaegis
Copy link
Owner

Project is Tim license, welcome your contribution.Looking forward to your pr.

@petrisorionel
Copy link
Author

it is my first PR on github so I receive this error, any idea?

git push origin HEAD warning: ----------------- SECURITY WARNING ---------------- warning: | TLS certificate verification has been disabled! | warning: --------------------------------------------------- warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information. info: please complete authentication in your browser... warning: ----------------- SECURITY WARNING ---------------- warning: | TLS certificate verification has been disabled! | warning: --------------------------------------------------- warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information. remote: Permission to fungaegis/pytest-failed-screenshot.git denied to petrisorionel. fatal: unable to access 'https://github.com/fungaegis/pytest-failed-screenshot.git/': The requested URL returned error: 403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants