improved try-either function #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it would only take a single form as the body now it returns the last item in the body as a right, as is normal
|
I can't understand what conflicts this branch has, I have updated latest upstream locally with no conflicts :( |
|
We can use (defmacro try-either [body]
`(try (right (do ~@body)) (catch Exception e# (left e#))) |
|
It seems there are still some merge conflicts, I can't merge this from the web interface. |
|
Fixed merge issue. Also, sorry about not spotting the need to separate js and java errors, I'm new to cljc so this stuff escaped my thought process. |
|
@dialelo this doesn't appear to be my PR that is breaking the tests... |
|
@shmish111: Agreed. See #160. |
|
Thanks a lot for your time and sorry for my delay. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it would only take a single form as the body, now it returns the last item in the body as a right, as is normal