Patch cljs tests #159
Merged
Patch cljs tests #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function in question is marked internal, so this should not be a breaking API change.
try-either was previously not implemented for clojurescript, causing try-success-test and try-exception-test to fail. This requires the try-either macro to detect when it is being expanded in a cljs namespace, as reader conditionals have already been expanded by the time macros are evaluated. See https://groups.google.com/forum/#!topic/clojurescript/iBY5HaQda4A for a discussion of the approach used.
Added type hints to avoid reflecting on fields at runtime. This should provide a significant performance improvement for hot code. Note, there is a trade-off with this approach: third party types will no longer be useable in place of cats types because the field references are no longer reflectively looked up by name but statically determined. If this becomes a problem a better approach would be to add protocols for retrieving shared values instead of direct field access.
The cljs tests should fail for this commit. - Cosmetic tweaks - Rename main to -main - Use when-not and (aget js/process "exit") instead of (set! (.-exitCode js/process) n) See #158
|
@sfnelson et al., feel free to make a PR against |
|
I think the call stack size error is unrelated to the other changes. It occurred in a different function for me while I was running tests earlier today. |
|
The failure seems rather arbitrary and, as you say, unrelated to these changes. I was able to restart the build and turn everything green. |
|
I had to leave the tests running for 10 minutes before it occurred for me locally. I think it depends on the seed given to quick-check, which unfortunately isn't printed when tests fail. |
This was referenced Mar 1, 2016
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsumes #157.
See failing test output.