Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection warnings with *warn-on-reflection* enabled #152

Closed
serioga opened this issue Feb 21, 2016 · 3 comments
Closed

Reflection warnings with *warn-on-reflection* enabled #152

serioga opened this issue Feb 21, 2016 · 3 comments

Comments

@serioga
Copy link

serioga commented Feb 21, 2016

If I enable *warn-on-reflection* globally then there are warnings in cats code.

Reflection warning, cats/context.cljc:38:19 - call to java.lang.IllegalArgumentException ctor can't be resolved.
Reflection warning, cats/util.cljc:34:14 - call to method write on java.io.Writer can't be resolved (argument types: unknown).
Reflection warning, cats/monad/maybe.cljc:65:17 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:70:17 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:100:17 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:183:12 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:159:19 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:165:19 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:166:19 - reference to field v on java.lang.Object can't be resolved.
Reflection warning, cats/monad/either.cljc:174:20 - reference to field v on java.lang.Object can't be resolved.
@ghost
Copy link

ghost commented Feb 23, 2016

Thanks for reporting, we can try to get rid of those, maybe even enable *warn-on-reflection* on tests for detecting these things.

@sfnelson
Copy link
Contributor

sfnelson commented Mar 1, 2016

This issue can probably be closed, unless you want to keep it open to track the remaining reflection warnings in the cats.labs.* namespaces

@ghost
Copy link

ghost commented Mar 1, 2016

If there are still a few warnings under cats.labs.* let's leave this open. We'd like to avoid reflection ieverywhere f it's possible.

@serioga serioga closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants