Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix Domain Socket on Windows #244

Closed
Rolice opened this issue Jul 26, 2021 · 2 comments · Fixed by #317
Closed

Unix Domain Socket on Windows #244

Rolice opened this issue Jul 26, 2021 · 2 comments · Fixed by #317

Comments

@Rolice
Copy link
Contributor

Rolice commented Jul 26, 2021

Hello,
Is there a reason why -unix flag is disabled on Windows? As I understand, this kind of support for local sockets was added in Windows 10, somewhere in 2018. Recently, I have cloned the project and allowed the flag and its usage in a custom build. The application behaves correctly and bin\go_build_main.exe -plaintext -unix "*.sock" list (also the direct method calls) work as expected.

The only change I have applied is to add windows target to the +build in ~\grpcurl\cmd\grpcurl\unix.go:

// +build darwin dragonfly freebsd linux netbsd openbsd solaris windows
@DSanchen
Copy link

I would also like to have the -unix flag available on windows, but would rather rely on a binary...

@jhump
Copy link
Contributor

jhump commented Jan 10, 2022

Pull requests welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants