Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review approach to AIP010KeyValueStorage #12

Closed
fulldecent opened this issue Jul 13, 2019 · 1 comment
Closed

Review approach to AIP010KeyValueStorage #12

fulldecent opened this issue Jul 13, 2019 · 1 comment

Comments

@fulldecent
Copy link
Owner

This project makes the assertion:

Best practice with Aion is to explicitly define all storage locations using an enum and then use these enums for all calls to putStorage. This avoids overlapping storage, which is also a vulnerability.

And the potentially controversial:

Also, use static storage only for recursive call state and configuration options which apply to all onchain transactions.

Seeking to review this statement with AVM team to ensure we are aligned.

Additionally we find that the current API for storing to blockchain is likely to (and may actually have) result in insecure applications.

Upstream ticket: aionnetwork/AVM#399

@fulldecent
Copy link
Owner Author

Reported upstream to aionnetwork/AVM#402. Not a blocker for this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant