-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: output umi grouping metrics #1021
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 95.64% 95.65%
=======================================
Files 126 126
Lines 7395 7403 +8
Branches 498 521 +23
=======================================
+ Hits 7073 7081 +8
Misses 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/test/scala/com/fulcrumgenomics/umi/GroupReadsByUmiTest.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -267,6 +269,10 @@ class GroupReadsByUmiTest extends UnitSpec with OptionValues with PrivateMethodT | |||
|
|||
hist.toFile.exists() shouldBe true | |||
|
|||
// TODO: Create a more comprehensive test case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO: Create a more comprehensive test case | |
// TODO: Consider creating more unit tests that vary the following metric fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@znorgaard how about adding to existing tests? E.g.
it should "exclude reads that contain an N in the UMI" in { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nh13, just add the metric generation and check to those other tests?
That would work. I generally like to see a "complex" test case where non-zero values are generated for each metric entry all at once. But, in this specific case we're pulling from existing variables, so individual tests might be good enough.
Closes #1020
This PR optionally emits a new metric file with read filtering statistics generated by GroupReadsByUmi.