Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output umi grouping metrics #1021

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: output umi grouping metrics #1021

wants to merge 5 commits into from

Conversation

znorgaard
Copy link
Contributor

@znorgaard znorgaard commented Dec 16, 2024

Closes #1020

This PR optionally emits a new metric file with read filtering statistics generated by GroupReadsByUmi.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (1c96bd7) to head (6b427fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   95.64%   95.65%           
=======================================
  Files         126      126           
  Lines        7395     7403    +8     
  Branches      498      521   +23     
=======================================
+ Hits         7073     7081    +8     
  Misses        322      322           
Flag Coverage Δ
unittests 95.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clintval clintval assigned znorgaard and unassigned clintval Dec 16, 2024
Copy link
Member

@clintval clintval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final suggestions from me. Looks good!

@tfenne or @nh13 do you want to give a pass?

@@ -267,6 +269,10 @@ class GroupReadsByUmiTest extends UnitSpec with OptionValues with PrivateMethodT

hist.toFile.exists() shouldBe true

// TODO: Create a more comprehensive test case
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Create a more comprehensive test case
// TODO: Consider creating more unit tests that vary the following metric fields

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znorgaard how about adding to existing tests? E.g.

it should "exclude reads that contain an N in the UMI" in {

Copy link
Contributor Author

@znorgaard znorgaard Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nh13, just add the metric generation and check to those other tests?

That would work. I generally like to see a "complex" test case where non-zero values are generated for each metric entry all at once. But, in this specific case we're pulling from existing variables, so individual tests might be good enough.

@clintval clintval assigned nh13 and tfenne and unassigned clintval Dec 16, 2024
@clintval clintval marked this pull request as ready for review December 16, 2024 20:04
@clintval clintval requested review from nh13 and tfenne as code owners December 16, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupReadsByUmi should emit an additional metrics file
4 participants