Replace rust-i18n with phf string maps and simple replaces #1428
+163
−353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1426 for comparison. Strings are now
&'static str
asphf::Map
entries, placeholder substitution is simplystr::replace
, no complex logic. Executable size is down 1MB (!).Downsides are 1. build.rs, 2.
str::replace
is not enough for complex translations.Currently both the
$kt:ident = $kt:expr
and$kt:literal => $kv:expr
forms oft!
are still supported, but I doubt if they really differ.