Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Trippy into multiple crates #1145

Merged
merged 3 commits into from
May 18, 2024
Merged

Split Trippy into multiple crates #1145

merged 3 commits into from
May 18, 2024

Conversation

fujiapple852
Copy link
Owner

@fujiapple852 fujiapple852 commented May 16, 2024 •
edited
Loading

Closes #1141

@fujiapple852 fujiapple852 marked this pull request as draft May 16, 2024 10:06
@fujiapple852 fujiapple852 force-pushed the refactor-crates-core branch 2 times, most recently from 68cf815 to e54dc0a Compare May 16, 2024 10:14
@fujiapple852 fujiapple852 force-pushed the refactor-crates-core branch 7 times, most recently from abc1490 to 77e463e Compare May 17, 2024 14:13
@fujiapple852 fujiapple852 marked this pull request as ready for review May 17, 2024 14:21
@fujiapple852 fujiapple852 changed the title Refactor crates core Split Trippy into multiple crates May 17, 2024
@fujiapple852 fujiapple852 requested a review from c-git May 17, 2024 14:27
@fujiapple852 fujiapple852 self-assigned this May 17, 2024
fujiapple852
fujiapple852 commented May 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
c-git
c-git approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@c-git c-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very happy with this PR. I did leave a few comments but none of them are show stoppers. I can try to do the removal of anyhow if you'd like. I've never done it before but I can look at how it's done in the privilege crate and try to pattern on that.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
README.md Show resolved Hide resolved
crates/trippy-privilege/src/lib.rs Outdated Show resolved Hide resolved
crates/trippy-privilege/src/lib.rs Outdated Show resolved Hide resolved
crates/trippy-privilege/src/lib.rs Outdated Show resolved Hide resolved
crates/trippy-privilege/src/lib.rs Show resolved Hide resolved
crates/trippy-core/Cargo.toml Show resolved Hide resolved
@fujiapple852 fujiapple852 force-pushed the refactor-crates-core branch 3 times, most recently from 8826530 to 2db027b Compare May 18, 2024 06:21
@fujiapple852 fujiapple852 force-pushed the refactor-crates-core branch 8 times, most recently from c0167ae to 98cf608 Compare May 18, 2024 06:55
@fujiapple852 fujiapple852 merged commit ecfc94c into master May 18, 2024
19 checks passed
@fujiapple852 fujiapple852 deleted the refactor-crates-core branch May 18, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wgreenberg wgreenberg wgreenberg left review comments

@c-git c-git c-git approved these changes

Assignees

@fujiapple852 fujiapple852

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate lib and bin dependencies
3 participants
@fujiapple852 @wgreenberg @c-git