-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight lost probes in sample history #1247
Comments
Yeah I think that would be more intuitive when reading the chart and would make nodes that never responded have a full bar instead of an empty bar which might be better. I think a full bar is better but I guess that's subjective. |
I actually did this in an early version of Trippy (red vertical bar for 0), but I had to vendor and modify |
Is it possible to create a derived widget with the alternate behaviour? Or perhaps a toggle to choose the behaviour as I can imagine other cases where an empty space is the preferred behaviour. |
Feature request: ratatui/ratatui#1325 |
When a probe times out (does not respond before a round ends) or fails to send (due to a local network error) the samples chart shown it as the absence of a value (a blank vertical bar). For example:
It is desirable to show
Awaited
(i.e. timed out) andFailed
probes as solid vertical lines of different colours to make the distinction clearer.The text was updated successfully, but these errors were encountered: