Don't use die when exiting successfully

[lorenzleutgeb]

I was very surprised to get non-zero exit codes for these invocations:

> latexdiff-vc --version ; echo $?
This is LATEXDIFF-VC 1.3.1.1
  (c) 2005-2020 F J Tilmann
255
> latexdiff --version ; echo $?
This is LATEXDIFF 1.3.1.1 (Algorithm::Diff 1.15 so, Perl v5.34.0)
  (c) 2004-2020 F J Tilmann
255

It turns out that you use die to print the version string and exit:

latexdiff/latexdiff-vc

Line 150 in af22466

die $versionstring ;

However, die sets a non-zero exit code, indicating an error. When printing the version string is everything that the program should do, then I'd also expect it to exit with an exit code of zero once that's done.

The documentation for die states:

If you need to exit the process with a specific exit code, see exit.

IMO, print followed by exit should be used, like here:

latexdiff/latexdiff

Lines 490 to 491 in af22466

	print STDERR $versionstring ;
	exit 0;

[ftilmann]

Thanks for reporting. This seems a duplicate of #248 and should be fixed on master (and actually in the very latest release, which was made just after). I will close. Let me know if there is still a problem.

[lorenzleutgeb]

Yes, sorry for duplicating, and thanks for fixing that issue, but as of 2022-01-28 master points at af22466 which I am referring to. It seems that you missed latexdiff-vc. Please fix and/or reopen.