Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive error message for incorrect column selections #138

Closed
MarcusKlik opened this issue Mar 14, 2018 · 2 comments
Closed

More descriptive error message for incorrect column selections #138

MarcusKlik opened this issue Mar 14, 2018 · 2 comments
Assignees
Milestone

Comments

@MarcusKlik
Copy link
Collaborator

by mail, from Jean-Luc:

currently, the following incorrect column selection leads to an error message that's not very descriptive:

# write some data
temp_file <- tempfile()
fst::write.fst(data.frame(A = 1:26, B = LETTERS), temp_file)
 
# incorrect column selection
fst::read_fst(temp_file, columns = "b")
#> Error in fst::read_fst(temp_file, columns = c("B", "a")) : 
#>  Selected column not found.

It would be nice to have the error message reflect the incorrect column name (a in this case).

@MarcusKlik MarcusKlik self-assigned this Mar 14, 2018
@MarcusKlik MarcusKlik added this to the fst v0.8.6 milestone Mar 14, 2018
@Moohan
Copy link

Moohan commented Nov 14, 2019

Any update on this, I was just about to post a new request for it, as I'm having issues and the error message could definitely be more helpful! 😄

@MarcusKlik
Copy link
Collaborator Author

Hi @Moohan, thanks for your request.

I've updated the error message, an incorrect column selection now leads to:

# write some data
temp_file <- tempfile()
fst::write.fst(data.frame(A = 1:26, B = LETTERS), temp_file)

# incorrect column selection
fst::read_fst(temp_file, columns = c("b", "A"))
#> Error in fst::read_fst(temp_file, columns = c("b", "A")): Column 'b' not found

short but informative 😸

@MarcusKlik MarcusKlik modified the milestones: Candidate, fst v0.9.2 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants