From d4cc86aba53d78cf1e10a4c075305d2f26ea4332 Mon Sep 17 00:00:00 2001 From: Hannes Schulz Date: Thu, 14 Mar 2024 00:01:57 +0100 Subject: [PATCH 1/3] document that `credential` needs to be from azure.identity.aio if it's a sync credential, then the weakref.finalize call will cause an error, close() -> None cannot be awaited. --- adlfs/spec.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adlfs/spec.py b/adlfs/spec.py index 5976d185..93a63fde 100644 --- a/adlfs/spec.py +++ b/adlfs/spec.py @@ -147,9 +147,9 @@ class AzureBlobFileSystem(AsyncFileSystem): request session. See http://azure.microsoft.com/en-us/documentation/articles/storage-configure-connection-string/ for the connection string format. - credential: TokenCredential or SAS token + credential: (async!) TokenCredential or SAS token The credentials with which to authenticate. Optional if the account URL already has a SAS token. - Can include an instance of TokenCredential class from azure.identity + Can include an instance of TokenCredential class from azure.identity.aio. blocksize: int The block size to use for download/upload operations. Defaults to hardcoded value of ``BlockBlobService.MAX_BLOCK_SIZE`` From 794ca7794fb22bf76dfdc7ac2eab94d05c1238a4 Mon Sep 17 00:00:00 2001 From: Tom Augspurger Date: Sat, 13 Apr 2024 07:59:28 -0500 Subject: [PATCH 2/3] Update adlfs/spec.py --- adlfs/spec.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adlfs/spec.py b/adlfs/spec.py index 93a63fde..a4e6a1cd 100644 --- a/adlfs/spec.py +++ b/adlfs/spec.py @@ -147,7 +147,7 @@ class AzureBlobFileSystem(AsyncFileSystem): request session. See http://azure.microsoft.com/en-us/documentation/articles/storage-configure-connection-string/ for the connection string format. - credential: (async!) TokenCredential or SAS token + credential: azure.core.credentials.AsyncTokenCredential or SAS token The credentials with which to authenticate. Optional if the account URL already has a SAS token. Can include an instance of TokenCredential class from azure.identity.aio. blocksize: int From 8a8e9dac2ab4c665cab2002c09e0d8e6cb48bd1e Mon Sep 17 00:00:00 2001 From: Tom Augspurger Date: Sat, 13 Apr 2024 08:00:01 -0500 Subject: [PATCH 3/3] Update adlfs/spec.py --- adlfs/spec.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adlfs/spec.py b/adlfs/spec.py index a4e6a1cd..f2f45f1a 100644 --- a/adlfs/spec.py +++ b/adlfs/spec.py @@ -147,7 +147,7 @@ class AzureBlobFileSystem(AsyncFileSystem): request session. See http://azure.microsoft.com/en-us/documentation/articles/storage-configure-connection-string/ for the connection string format. - credential: azure.core.credentials.AsyncTokenCredential or SAS token + credential: azure.core.credentials_async.AsyncTokenCredential or SAS token The credentials with which to authenticate. Optional if the account URL already has a SAS token. Can include an instance of TokenCredential class from azure.identity.aio. blocksize: int