Hard to read code when using Thoth.Json

[lydell]

https://thoth-org.github.io/Thoth.Json/

I think this is very hard to read when the arguments to map3 after the fun are bunched up to the right. At first glance it looks like they are part of the | None -> branch.

Decode.map3 (fun aggregateId event commitPayload ->
    match commitPayload with
    | Some payload ->
        Some
            { AggregateId = AggregateId aggregateId
              Event = event
              Payload = payload }
    | None -> None) (Decode.field "aggregate_id" Decode.string) (Decode.field "event" Decode.string) decodePayload

Something like this would be better:

Decode.map3
    (fun aggregateId event commitPayload ->
        match commitPayload with
        | Some payload ->
            Some
                { AggregateId = AggregateId aggregateId
                  Event = event
                  Payload = payload }
        | None -> None
    )
    (Decode.field "aggregate_id" Decode.string)
    (Decode.field "event" Decode.string)
    decodePayload

Thanks!

[nojaf]

Fantomas has as general rule if it fits on one line it should.
You can change the PageWidth to something smaller:
See:
https://jindraivanek.gitlab.io/fantomas-ui/#?fantomas=preview&code=CIUwxg9gJiB0C2BDADgZgAQAoBmBXAduogObEBOIxiALiAJJTogBuI+16k88AltQAqIAngBsIiRgFoAfAFgAUOiXok1MAAtOEbn0GjxjAO591C5egA+6AMraQ6ZMLET0Ms+eW34Idx48BvdABBUgoqWgZ0AF5g0MoaekYScniIqF8-DwBRVnZoplzqDMzlPWdGGMd9FwBfDKsAOQh8exl0JpaASixQSBhYbB4QEUYAImSwhIB9HihR9F7oOABnajIefGJuzEX+weGxljZqed2VtY2t9Bg+kDKDIA&config=N4IgCghg5gpg6gSwCYBcAWIBcBGADLgXyA
The result is somewhat smaller but not what you propose.

Another workaround could to add // at the end where you wish to force a line break.
However, I discovered #687 while trying that.

[nojaf]

Related https://github.com/fsprojects/fantomas/pull/1007/files#diff-a1b0b9a30fd94fe61b35a1a52ce27955R1514.
Maybe that check needs to be extended.

[nojaf]

Fixed as part of #1202.
See example.

[lydell]

Awesome! Thank you so much! 🥇