From b600272e86d0f482fc0a2a375aa47aa3c2acd39d Mon Sep 17 00:00:00 2001 From: Rupert Muchembled Date: Mon, 5 Nov 2018 17:32:34 +0000 Subject: [PATCH 1/3] Add "release" as a special word to Pluralizer Currently, "releases" takes the "sis" <-> "ses" suffix rule, and therefore becomes "releasis" --- src/CommonRuntime/Pluralizer.fs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/CommonRuntime/Pluralizer.fs b/src/CommonRuntime/Pluralizer.fs index c6011e314..098f2e018 100644 --- a/src/CommonRuntime/Pluralizer.fs +++ b/src/CommonRuntime/Pluralizer.fs @@ -154,6 +154,7 @@ let private tables = lazy( "pro", "pros", "" "rabies", "", "" "radius", "radiuses", "radii" + "release", "releases", "" "rhino", "rhinos", "" "salmon", "", "" "scissors", "", "" From 4871e124b01a28fd37057b4eb424e84ce7023493 Mon Sep 17 00:00:00 2001 From: Rupert Muchembled Date: Mon, 5 Nov 2018 19:32:50 +0000 Subject: [PATCH 2/3] Add test cases for release<->releases pluralization --- tests/FSharp.Data.Tests/NameUtils.fs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/FSharp.Data.Tests/NameUtils.fs b/tests/FSharp.Data.Tests/NameUtils.fs index 5fce560f7..61ab0b982 100644 --- a/tests/FSharp.Data.Tests/NameUtils.fs +++ b/tests/FSharp.Data.Tests/NameUtils.fs @@ -122,6 +122,7 @@ let ``Can pluralize names``() = check "woman" "women" check "index" "indices" check "status" "statuses" + check "release" "releases" [] let ``Can singularize names``() = @@ -146,3 +147,4 @@ let ``Can singularize names``() = check "indices" "index" check "indexes" "index" check "statuses" "status" + check "releases" "release" From a846a89ef67097709533035d8988f5b54216c4d2 Mon Sep 17 00:00:00 2001 From: Rupert Muchembled Date: Wed, 21 Nov 2018 20:01:00 +0000 Subject: [PATCH 3/3] Add "choice" as a special word for Pluralizer --- src/CommonRuntime/Pluralizer.fs | 1 + tests/FSharp.Data.Tests/NameUtils.fs | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/CommonRuntime/Pluralizer.fs b/src/CommonRuntime/Pluralizer.fs index 098f2e018..ec6676472 100644 --- a/src/CommonRuntime/Pluralizer.fs +++ b/src/CommonRuntime/Pluralizer.fs @@ -98,6 +98,7 @@ let private tables = lazy( "child", "children", "" "chassis", "", "" "chinese", "", "" + "choice", "choices", "" "clippers", "", "" "cod", "", "" "codex", "codices", "" diff --git a/tests/FSharp.Data.Tests/NameUtils.fs b/tests/FSharp.Data.Tests/NameUtils.fs index 61ab0b982..5fc45ceab 100644 --- a/tests/FSharp.Data.Tests/NameUtils.fs +++ b/tests/FSharp.Data.Tests/NameUtils.fs @@ -123,6 +123,7 @@ let ``Can pluralize names``() = check "index" "indices" check "status" "statuses" check "release" "releases" + check "choice" "choices" [] let ``Can singularize names``() = @@ -148,3 +149,4 @@ let ``Can singularize names``() = check "indexes" "index" check "statuses" "status" check "releases" "release" + check "choices" "choice"