Additional maintainers

[nojaf]

Hey @eiriktsarpalis,

What do you think about bringing in more maintainers for the project? Noticed a few of @bartelink's PRs haven't been reviewed yet. It'd be cool to get some extra hands for regular upkeep.

I'm up for helping out. No big deal if there's someone better suited, but I do use Argu and wouldn't mind pitching in. Maybe setting up a team under the fsprojects org could work well?

More folks on board would mean quicker PR reviews and smoother Argu updates. Just a thought!

[eiriktsarpalis]

I was pretty sure I had handed over maintenance for this library a long time ago, so I was surprised to find out I'm still listed as maintainer. I don't believe I'm an admin on fsprojects, so it would be best if somebody from that body handled this.

[nojaf]

Aha, interesting. @sergey-tihon do you have any insights here?
Who are the current maintainers now?

[sergey-tihon]

One of these gentlemen's @cloudRoutine @palladin @haf
Or we don't have a current one

[bartelink]

I work on systems that use it (and https://github.com/jet/dotnet-templates promulgates it) so will watch and participate in general. I'm happy to act as a official secondary if it helps; I'm sure nobody capable is bored, but I feel I'm already primary on enough projects that deserve more attention!

[sergey-tihon]

I've added an admin role to @nojaf and @bartelink.
Welcome aboard!

p.s. please update the list of active maintainers in readme.

[nojaf]

Thank you @sergey-tihon!
@eiriktsarpalis can you add fsprojects as owner for the NuGet package? That way Sergey can create a new NuGet key we can add to this repositories secrets.

[eiriktsarpalis]

@nojaf done.

[sergey-tihon]

Thank you @eiriktsarpalis

Package accepted, NUGET_KEY with the right to push new Argu versions added to project secrets

[nojaf]

Alright, we are almost there. The last problem I think is that we cannot publish ls?

/home/runner/work/Argu/Argu> "/usr/share/dotnet/dotnet"  nuget push -s https://api.nuget.org/v3/index.json -k *** /home/runner/work/Argu/Argu/artifacts/ls.6.1.2.nupkg (In: false, Out: false, Err: false)
Pushing ls.6.1.2.nupkg to 'https://www.nuget.org/api/v2/package'...
  PUT https://www.nuget.org/api/v2/package/
  Forbidden https://www.nuget.org/api/v2/package/ [372](https://github.com/fsprojects/Argu/actions/runs/7194004330/job/19593585675#step:5:373)ms
error: Response status code does not indicate success: 403 (The specified API key is invalid, has expired, or does not have permission to access the specified package.).

@eiriktsarpalis what is the story there? Should that be published? That is the sample, right?

The NuGet key only works for Argu probably, @sergey-tihon?

[nojaf]

To clarify, https://www.nuget.org/packages/Argu/6.1.2 did publish correctly.

[bartelink]

@nojaf Yes, that's only a sample
I may have been agressive in some Directory.props files - should be able to remediate by setting IsPackable false on all but the prod one

The NuGet key was clearly (and this is standard good policy) configured to only allow pushing new versions of existing packages, which is a failsafe to trap just this sort of snafu

[bartelink]

Putting a

    <IsPackable>false</IsPackable>

in the LS fsproj should sort it...

---

Oh great, FAKE complaining at me...
... why did I close #197
(answer turns out to be: because just bumping the tool version is not enough)

👇 #201 should hopefully solve the problem

[nojaf]

Okay, since we've covered everything, it's time to wrap this up. Thanks to everyone for demonstrating how open-source software can thrive with willing collaboration.