-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TPSDK and paket targets #1250
Conversation
Error in CI:
|
OK, well, there seem to be problems building the repo. On my local machine I get
|
Ugh, we need to update the version of sourcelink used to the non-clitool version to sidestep this class of errors: https://github.com/dotnet/sourcelink |
@baronfel It looks like the build with the MSBuild toolchain has been busted for a while, even before 3.0.0 release I just added a commit to remove the use of the MSBuild toolchain altogether, to see how it goes, and see if we can get CI green If we get it green we can consider bringing back the MSBuild toolchain - though as long as we're testing on .NET Core and .NET Framework it may be enough (obviously it would be good to test on Mono too, but maybe the |
Hmmm
So that's a good sign. |
ok, green it is. And Mono testing is included on travis:
Will pull this and tag |
@dsyme do you want me to do the 3.01 release today? Or I can give you permission to the nuget package as well so you can do it |
Released 3.01 and added you as owner of the nuget package |
Thank you! Great to have this released. |
This updates the TPSDK to contain the fix for #1249
thanks
don