Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling #2

Open
justincy opened this issue Dec 22, 2016 · 1 comment
Open

Error Handling #2

justincy opened this issue Dec 22, 2016 · 1 comment

Comments

@justincy
Copy link
Member

The components don't do any error handling beyond console.error() logging. We need to come up with error states for the components as well as global error hooks or events.

@justincy
Copy link
Member Author

In fs-webcomponents/sample-app#26 we added toast notifications to the sample app by listening to all fs-request response events that bubbled up. But the error messages are not particularly helpful. The best we can do is say there was an error and show the HTTP response status code and status text.

Ideally each component would listen for errors and attempt to provide a more helpful error message while also having its own error state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant