Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to specify chapter when multiple with same name exist? #31

Open
ScherisMarie opened this issue Mar 11, 2021 · 6 comments · May be fixed by #54
Open

Not possible to specify chapter when multiple with same name exist? #31

ScherisMarie opened this issue Mar 11, 2021 · 6 comments · May be fixed by #54

Comments

@ScherisMarie
Copy link

https://mangadex.org/title/51497/the-villainess-became-a-commoner

When I ran this script last night, the chapter list returned “1, 1, 2” for the results to choose to download.

Unless I’m missing something, typing in “1” only downloaded the first iteration of Ch1, so I had to download them all to get the second one that I actually wanted.

Did I miss something or is there no way to currently specify which one to download when multiple of the same chapter number exist?

@frozenpandaman
Copy link
Owner

Not currently possible, sorry! From the readme:

Current limitations

  • The script will download all available releases (in your language) of each chapter specified.

At some point I'll figure this out but hopefully for now it's not too limiting.

@frozenpandaman
Copy link
Owner

@ScherisMarie What would your preferred UI/UX be for this? e.g. if you type in "1", should all the groups that have released a chapter numbered 1 be displayed, and there's a prompt asking you to specify which to download every time this occurs?

@ScherisMarie
Copy link
Author

That would work. Assuming the "1" listings in that example would show the group names to tell them apart?

@frozenpandaman
Copy link
Owner

Yep, that's what I meant by "all the groups that have released a chapter numbered 1 [would] be displayed" haha. Thanks!

@orbea
Copy link
Contributor

orbea commented May 18, 2021

A prompt for each individual chapter on a long series with more than one translation group might be somewhat tedious. :)

@ArjixWasTaken
Copy link

ArjixWasTaken commented Aug 29, 2021

I suggest for the user to save in a json file a priority list, where they will have the group ids they want to be prioritized.
That way when there are multiple groups, it will look at the json, if the group is in that json and its ranked higher than the other groups, it shall download that.
And if that group is not included in the priority list and no group from that list has a release of that chapter then it picks a random one.

I can try adding this as a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants