Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use last version from changelog file instead of previous git tag #82

Merged
merged 8 commits into from
Jun 2, 2019
Merged

🐛 Use last version from changelog file instead of previous git tag #82

merged 8 commits into from
Jun 2, 2019

Conversation

kefranabg
Copy link
Contributor

No description provided.

@frinyvonnick
Copy link
Owner

frinyvonnick commented May 28, 2019 •
edited
Loading

Closes #80

@frinyvonnick frinyvonnick changed the title ✨ Get changelog last version 🐛 Use last version from changelog file instead of previous git tag May 28, 2019
@frinyvonnick frinyvonnick added the work in progress Still in progress label May 28, 2019
@frinyvonnick frinyvonnick removed the work in progress Still in progress label May 30, 2019
bpetetot
bpetetot approved these changes Jun 1, 2019
View reviewed changes
Copy link
Collaborator

@bpetetot bpetetot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one small comment to check 👍

packages/gitmoji-changelog-markdown/src/index.js Show resolved Hide resolved
@frinyvonnick frinyvonnick merged commit d3c49d0 into frinyvonnick:master Jun 2, 2019
@kefranabg kefranabg deleted the feat/get_changelog_last_version branch June 3, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick left review comments

@bpetetot bpetetot bpetetot approved these changes

@fabienjuif fabienjuif Awaiting requested review from fabienjuif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kefranabg @frinyvonnick @bpetetot