-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐳 Init dockerfile #61
🐳 Init dockerfile #61
Conversation
Thank you @lhauspie You make a good choice I guess. But let it this way:
|
👍 Great job! |
I agree with @bpetetot and want to add this: It should be an other PR/Issue |
I agree too with @bpetetot, but I didn't update the I think, like @fabienjuif, it's part of another issue about "Include the docker image build and publish in travis". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
So I merge it @bpetetot accordingly to previous comments ? |
Related issue #64 |
Co-Authored-By: lhauspie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @lhauspie 👍
Thank's. |
I had 2 options to write this Dockerfile:
gitmoji-changelog
"binary" from sourceEven if the second option offers a lighter Docker Image (102MB) compared to the first one (263MB), I chose the first one because I think we cannot build a Docker Image based on "binary" from "https://registry.npmjs.org/gitmoji-changelog" until it is available (but I maybe wrong, just tell me).
So, this Dockerfile:
gitmoji-changelog
yarn
/usr/src/gitmoji-changelog/node_modules/.bin/gitmoji-changelog
Usage
docker run --rm -v $(pwd):/usr/src/app gitmoji-changelog
where$(pwd)
is the folder of the project you want to generate the CHANGELOG.md.All Commands, Positionals and Options are available with
docker run
command.For instance,
docker run --rm -v $(pwd):$(pwd) -w $(pwd) gitmoji-changelog:1.0.0 --help
outputs:Closes #29