Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Do not override the top of the existing file #53

Merged
merged 10 commits into from
Oct 27, 2018
Merged

✨ Do not override the top of the existing file #53

merged 10 commits into from
Oct 27, 2018

Conversation

fabienjuif
Copy link
Collaborator

@fabienjuif fabienjuif commented Oct 27, 2018 •
edited
Loading

fixes #47

WIP

  • Need to simplify a little
  • Need tests
  • If I replay the CLI, I have "next" commits adding again and again

@fabienjuif fabienjuif added the work in progress Still in progress label Oct 27, 2018
@fabienjuif fabienjuif self-assigned this Oct 27, 2018
@fabienjuif fabienjuif removed the work in progress Still in progress label Oct 27, 2018
bpetetot
bpetetot approved these changes Oct 27, 2018
View reviewed changes
Copy link
Collaborator

@bpetetot bpetetot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 seems great, just a question about temporary file (see comment)

packages/gitmoji-changelog-markdown/src/index.js Show resolved Hide resolved
@fabienjuif fabienjuif mentioned this pull request Oct 27, 2018
Open
@fabienjuif fabienjuif merged commit 15edd6c into master Oct 27, 2018
@fabienjuif fabienjuif deleted the sparkles/keepChangelogTop branch October 27, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpetetot bpetetot bpetetot approved these changes

@frinyvonnick frinyvonnick Awaiting requested review from frinyvonnick

Assignees

@fabienjuif fabienjuif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep top of changelog file and replace only the unknown tag part
2 participants
@fabienjuif @bpetetot