Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Check CLI version #52

Merged
merged 5 commits into from
Oct 27, 2018
Merged

✨ Check CLI version #52

merged 5 commits into from
Oct 27, 2018

Conversation

fabienjuif
Copy link
Collaborator

@fabienjuif fabienjuif commented Oct 26, 2018 •
edited
Loading

fixes #37

Note that I didn't found how to cancel promises.
So I put the process.exit(0) at the end.

@fabienjuif fabienjuif added the work in progress Still in progress label Oct 26, 2018
@fabienjuif fabienjuif self-assigned this Oct 26, 2018
@fabienjuif fabienjuif removed the work in progress Still in progress label Oct 26, 2018
bpetetot
bpetetot approved these changes Oct 27, 2018
View reviewed changes
Copy link
Collaborator

@bpetetot bpetetot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabienjuif fabienjuif merged commit 18ead38 into master Oct 27, 2018
@fabienjuif fabienjuif deleted the sparkles/check-version branch October 27, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick left review comments

@bpetetot bpetetot bpetetot approved these changes

Assignees

@fabienjuif fabienjuif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify that the client has the last version when he runs the CLI
3 participants
@fabienjuif @bpetetot @frinyvonnick