Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add the documentation site #194

Merged
merged 6 commits into from
Sep 25, 2020
Merged

📝 Add the documentation site #194

merged 6 commits into from
Sep 25, 2020

Conversation

endormi
Copy link
Contributor

@endormi endormi commented Sep 24, 2020

How to run the site?

Fixes #193

cd ./packages/gitmoji-changelog-documentation && docsify serve

@endormi endormi changed the title Add the documentation site :docs: Add the documentation site Sep 24, 2020
@frinyvonnick
Copy link
Owner

Hi @endormi,

Nice job 👍

There are missing part of the documentation especially the presets documentation. I would like to avoid duplicating files so you could move the original files in gitmoji-changelog-documentation package.

I will handle the deployment part since it involves having access to domain and web host accounts 😄

I will commit the configuration on your branch if it is ok with you? (I can do it later if you prefer 😉 )

@endormi
Copy link
Contributor Author

endormi commented Sep 25, 2020

Thanks @frinyvonnick 😃.

Oops, I only took the documentation.md file.

I will commit the configuration on your branch if it is ok with you? (I can do it later if you prefer 😉 )

Yeah that's fine 👍. Since you are already adding the config, could you maybe also add the rest of the documentation to the site?

@frinyvonnick
Copy link
Owner

Thought you would like to finish it but I can do it too 👌

@endormi
Copy link
Contributor Author

endormi commented Sep 25, 2020

Ok 👍.

@frinyvonnick
Copy link
Owner

I'll deploy in a further pull request because of github action limitation on forks 🤔

Thank you for your work @endormi 🙏

@frinyvonnick frinyvonnick merged commit 62ab467 into frinyvonnick:master Sep 25, 2020
@frinyvonnick
Copy link
Owner

@all-contributors please add endormi for doc

@allcontributors
Copy link
Contributor

@frinyvonnick

I've put up a pull request to add @endormi! 🎉

@endormi endormi deleted the docs branch September 25, 2020 11:50
@endormi endormi changed the title :docs: Add the documentation site 📝 Add the documentation site Sep 25, 2020
@endormi
Copy link
Contributor Author

endormi commented Sep 25, 2020

Oops accidentally used :docs: when meant to use 📝 😅

@frinyvonnick
Copy link
Owner

No problem, the site is available at https://docs.gitmoji-changelog.dev/#/ 🚀

frinyvonnick added a commit that referenced this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a documentation site
2 participants