✨ Support commit's URL and issues autolink in changelog #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpetetot
changed the title
bpetetot
changed the title
bpetetot
changed the title
bpetetot
commented
Sep 26, 2018
bpetetot
commented
Sep 26, 2018
| const packageInfo = await readPkgUp() | ||
| packageJson = packageInfo.pkg || {} | ||
| } catch (e) { | ||
| packageJson = {} |
There was a problem hiding this comment.
packageJson is already empty, no ?
| packageJson.repository = { url } | ||
| normalizePackageData(packageJson) | ||
| } catch (e) { | ||
| packageJson = {} |
There was a problem hiding this comment.
here you can return null directly we don't want to go further ?
frinyvonnick
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
gitmoji-changelog-core:
repoInfo.js: Extract git repo info frompackage.json, if not exists from .git remote originmeta.repositoryobject in the object generated by the core. it contains meta-information about the repository:{ type, domain, user, project, url, bugsUrl }gitmoji-changelog-markdown:
Here the result: CHANGELOG.md